2013-03-27 08:59:30

by Sachin Kamat

[permalink] [raw]
Subject: Re: [PATCH 1/1] mfd: adp5520: Use module_i2c_driver()

On 15 March 2013 17:10, Sachin Kamat <[email protected]> wrote:
> module_i2c_driver() removes some boilerplate and makes the code
> simple.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/mfd/adp5520.c | 12 +-----------
> 1 files changed, 1 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
> index 210dd03..5ab021f 100644
> --- a/drivers/mfd/adp5520.c
> +++ b/drivers/mfd/adp5520.c
> @@ -360,17 +360,7 @@ static struct i2c_driver adp5520_driver = {
> .id_table = adp5520_id,
> };
>
> -static int __init adp5520_init(void)
> -{
> - return i2c_add_driver(&adp5520_driver);
> -}
> -module_init(adp5520_init);
> -
> -static void __exit adp5520_exit(void)
> -{
> - i2c_del_driver(&adp5520_driver);
> -}
> -module_exit(adp5520_exit);
> +module_i2c_driver(adp5520_driver);
>
> MODULE_AUTHOR("Michael Hennerich <[email protected]>");
> MODULE_DESCRIPTION("ADP5520(01) PMIC-MFD Driver");
> --
> 1.7.4.1
>

ping...


2013-03-27 09:21:09

by Hennerich, Michael

[permalink] [raw]
Subject: AW: [PATCH 1/1] mfd: adp5520: Use module_i2c_driver()


________________________________________
Von: Sachin Kamat [[email protected]]
Gesendet: Mittwoch, 27. M?rz 2013 09:59
An: [email protected]; LKML
Cc: Hennerich, Michael; [email protected]; [email protected]
Betreff: Re: [PATCH 1/1] mfd: adp5520: Use module_i2c_driver()

On 15 March 2013 17:10, Sachin Kamat <[email protected]> wrote:
> module_i2c_driver() removes some boilerplate and makes the code
> simple.
>
> Signed-off-by: Sachin Kamat <[email protected]>

Acked-by: Michael Hennerich <[email protected]>

> ---
> drivers/mfd/adp5520.c | 12 +-----------
> 1 files changed, 1 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
> index 210dd03..5ab021f 100644
> --- a/drivers/mfd/adp5520.c
> +++ b/drivers/mfd/adp5520.c
> @@ -360,17 +360,7 @@ static struct i2c_driver adp5520_driver = {
> .id_table = adp5520_id,
> };
>
> -static int __init adp5520_init(void)
> -{
> - return i2c_add_driver(&adp5520_driver);
> -}
> -module_init(adp5520_init);
> -
> -static void __exit adp5520_exit(void)
> -{
> - i2c_del_driver(&adp5520_driver);
> -}
> -module_exit(adp5520_exit);
> +module_i2c_driver(adp5520_driver);
>
> MODULE_AUTHOR("Michael Hennerich <[email protected]>");
> MODULE_DESCRIPTION("ADP5520(01) PMIC-MFD Driver");
> --
> 1.7.4.1
>

ping...

2013-04-08 08:35:39

by Sachin Kamat

[permalink] [raw]
Subject: Re: [PATCH 1/1] mfd: adp5520: Use module_i2c_driver()

On 27 March 2013 14:50, Hennerich, Michael <[email protected]> wrote:
>
> ________________________________________
> Von: Sachin Kamat [[email protected]]
> Gesendet: Mittwoch, 27. M?rz 2013 09:59
> An: [email protected]; LKML
> Cc: Hennerich, Michael; [email protected]; [email protected]
> Betreff: Re: [PATCH 1/1] mfd: adp5520: Use module_i2c_driver()
>
> On 15 March 2013 17:10, Sachin Kamat <[email protected]> wrote:
>> module_i2c_driver() removes some boilerplate and makes the code
>> simple.
>>
>> Signed-off-by: Sachin Kamat <[email protected]>
>
> Acked-by: Michael Hennerich <[email protected]>
>

Ping Samuel.

--
With warm regards,
Sachin

2013-04-08 09:21:15

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH 1/1] mfd: adp5520: Use module_i2c_driver()

On Mon, Apr 08, 2013 at 02:05:37PM +0530, Sachin Kamat wrote:
> On 27 March 2013 14:50, Hennerich, Michael <[email protected]> wrote:
> >
> > ________________________________________
> > Von: Sachin Kamat [[email protected]]
> > Gesendet: Mittwoch, 27. M?rz 2013 09:59
> > An: [email protected]; LKML
> > Cc: Hennerich, Michael; [email protected]; [email protected]
> > Betreff: Re: [PATCH 1/1] mfd: adp5520: Use module_i2c_driver()
> >
> > On 15 March 2013 17:10, Sachin Kamat <[email protected]> wrote:
> >> module_i2c_driver() removes some boilerplate and makes the code
> >> simple.
> >>
> >> Signed-off-by: Sachin Kamat <[email protected]>
> >
> > Acked-by: Michael Hennerich <[email protected]>
> >
>
> Ping Samuel.
Patch applied to mfd-next, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/