Hi Jean-Nicolas,
On Mon, Feb 18, 2013 at 05:50:22PM +0100, Jean-Nicolas Graux wrote:
> Provides support for 1801 variant of stmpe gpio port expanders.
> This chip has 18 gpios configurable as GPI, GPO, keypad matrix,
> special key or dedicated key function.
>
> Note that special/dedicated key function is not supported yet.
>
> Change-Id: I6ea89af7b96e9a02478ebec3467291e7d7c510c9
No Change-Id, please.
> Signed-off-by: Jean-Nicolas Graux <[email protected]>
> ---
> drivers/gpio/gpio-stmpe.c | 52 +++++--
> drivers/input/keyboard/stmpe-keypad.c | 267 ++++++++++++++++++++++++++-------
> drivers/mfd/Kconfig | 1 +
> drivers/mfd/stmpe-i2c.c | 1 +
> drivers/mfd/stmpe.c | 97 +++++++++++-
> drivers/mfd/stmpe.h | 49 ++++++
> include/linux/mfd/stmpe.h | 3 +
> 7 files changed, 398 insertions(+), 72 deletions(-)
This should be splitted into 3 patches, an mfd one and then an input and a
gpio one. I would carry all 3 of them through the MFD tree on order to handle
build dependencies.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
On 04/08/2013 11:56 AM, Samuel Ortiz wrote:
> Hi Jean-Nicolas,
>
> On Mon, Feb 18, 2013 at 05:50:22PM +0100, Jean-Nicolas Graux wrote:
>> Provides support for 1801 variant of stmpe gpio port expanders.
>> This chip has 18 gpios configurable as GPI, GPO, keypad matrix,
>> special key or dedicated key function.
>>
>> Note that special/dedicated key function is not supported yet.
>>
>> Change-Id: I6ea89af7b96e9a02478ebec3467291e7d7c510c9
> No Change-Id, please.
>
>> Signed-off-by: Jean-Nicolas Graux <[email protected]>
>> ---
>> drivers/gpio/gpio-stmpe.c | 52 +++++--
>> drivers/input/keyboard/stmpe-keypad.c | 267 ++++++++++++++++++++++++++-------
>> drivers/mfd/Kconfig | 1 +
>> drivers/mfd/stmpe-i2c.c | 1 +
>> drivers/mfd/stmpe.c | 97 +++++++++++-
>> drivers/mfd/stmpe.h | 49 ++++++
>> include/linux/mfd/stmpe.h | 3 +
>> 7 files changed, 398 insertions(+), 72 deletions(-)
> This should be splitted into 3 patches, an mfd one and then an input and a
> gpio one. I would carry all 3 of them through the MFD tree on order to handle
> build dependencies.
>
> Cheers,
> Samuel.
>
Hello Samuel,
Ok, i do the split. I guess i should also rebase on latest 3.9 kernel.
Regards. J-Nicolas.
Hi Jean-Nicolas,
On Mon, Apr 08, 2013 at 12:04:18PM +0200, Jean-Nicolas GRAUX wrote:
> On 04/08/2013 11:56 AM, Samuel Ortiz wrote:
> >Hi Jean-Nicolas,
> >
> >On Mon, Feb 18, 2013 at 05:50:22PM +0100, Jean-Nicolas Graux wrote:
> >>Provides support for 1801 variant of stmpe gpio port expanders.
> >>This chip has 18 gpios configurable as GPI, GPO, keypad matrix,
> >>special key or dedicated key function.
> >>
> >>Note that special/dedicated key function is not supported yet.
> >>
> >>Change-Id: I6ea89af7b96e9a02478ebec3467291e7d7c510c9
> >No Change-Id, please.
> >
> >>Signed-off-by: Jean-Nicolas Graux <[email protected]>
> >>---
> >> drivers/gpio/gpio-stmpe.c | 52 +++++--
> >> drivers/input/keyboard/stmpe-keypad.c | 267 ++++++++++++++++++++++++++-------
> >> drivers/mfd/Kconfig | 1 +
> >> drivers/mfd/stmpe-i2c.c | 1 +
> >> drivers/mfd/stmpe.c | 97 +++++++++++-
> >> drivers/mfd/stmpe.h | 49 ++++++
> >> include/linux/mfd/stmpe.h | 3 +
> >> 7 files changed, 398 insertions(+), 72 deletions(-)
> >This should be splitted into 3 patches, an mfd one and then an input and a
> >gpio one. I would carry all 3 of them through the MFD tree on order to handle
> >build dependencies.
> >
> >Cheers,
> >Samuel.
> >
> Hello Samuel,
> Ok, i do the split. I guess i should also rebase on latest 3.9 kernel.
Or against mfd-next
(git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-next.git).
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/