2013-04-07 17:28:25

by Tejun Heo

Subject: [PATCH cgroup/for-3.10] devcg: remove broken_hierarchy tag

>From f913fbedbdfc08eeff742c4b3077e267d8fc867f Mon Sep 17 00:00:00 2001
From: Tejun Heo <[email protected]>
Date: Sun, 7 Apr 2013 10:25:39 -0700

bd2953ebbb ("devcg: propagate local changes down the hierarchy")
implemented proper hierarchy support. Remove the broken tag.

Signed-off-by: Tejun Heo <[email protected]>
Cc: Aristeu Rozanski <[email protected]>
---
Applying to cgroup/for-3.10.

Thanks.

security/device_cgroup.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/security/device_cgroup.c b/security/device_cgroup.c
index 221967d..994aecc 100644
--- a/security/device_cgroup.c
+++ b/security/device_cgroup.c
@@ -739,15 +739,6 @@ struct cgroup_subsys devices_subsys = {
.css_offline = devcgroup_offline,
.subsys_id = devices_subsys_id,
.base_cftypes = dev_cgroup_files,
-
- /*
- * While devices cgroup has the rudimentary hierarchy support which
- * checks the parent's restriction, it doesn't properly propagates
- * config changes in ancestors to their descendents. A child
- * should only be allowed to add more restrictions to the parent's
- * configuration. Fix it and remove the following.
- */
- .broken_hierarchy = true,
};

/**
--
1.8.1.4

2013-04-08 12:24:53

by Aristeu Rozanski

Subject: Re: [PATCH cgroup/for-3.10] devcg: remove broken_hierarchy tag

On Sun, Apr 07, 2013 at 10:28:18AM -0700, Tejun Heo wrote:
> From f913fbedbdfc08eeff742c4b3077e267d8fc867f Mon Sep 17 00:00:00 2001
> From: Tejun Heo <[email protected]>
> Date: Sun, 7 Apr 2013 10:25:39 -0700
>
> bd2953ebbb ("devcg: propagate local changes down the hierarchy")
> implemented proper hierarchy support. Remove the broken tag.
>
> Signed-off-by: Tejun Heo <[email protected]>
> Cc: Aristeu Rozanski <[email protected]>
> ---
> Applying to cgroup/for-3.10.

looks good, thanks Tejun

Acked-by: Aristeu Rozanski <[email protected]>

--
Aristeu