2013-04-08 14:34:47

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion

Hi Pali,

On Fri, Feb 15, 2013 at 11:56:49PM +0100, Pali Roh?r wrote:
> Driver twl4030-madc has hardcoded channel types (10 - battery current,
> 1 - battery temperature) and also conversation data in variable
> twl4030_divider_ratios. These hardcoded channels are incorrect for
> Nokia RX-51 board (where is channel 0 - battery temperature).
>
> For Nokia RX-51 there is rx51_battery power_supply driver which reporting
> battery information via twl4030_madc_conversion. But this driver needs
> raw values (not converted via some hardcoded functions). So this patch
> adding new parameter "raw" to struct twl4030_madc_request which tell
> twl4030-madc driver to not convert values, but rather return raw.
>
> Signed-off-by: Pali Roh?r <[email protected]>
> ---
> drivers/mfd/twl4030-madc.c | 14 ++++++++++----
> include/linux/i2c/twl4030-madc.h | 2 ++
> 2 files changed, 12 insertions(+), 4 deletions(-)
I appled this patch and the power one to my mfd-next tree.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/