2013-04-09 16:57:43

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v3 5/7] spi: spi-fsl-spi: Add support for setting a maximum number of bits per word

On Fri, Feb 15, 2013 at 04:52:25PM +0100, Andreas Larsson wrote:
> Acked-by: Anton Vorontsov <[email protected]>
> Signed-off-by: Andreas Larsson <[email protected]>

I'll apply this on account of it being part of the series and review
having been very slow but...

> /* Make sure its a bit width we support [4..16, 32] */
> if ((bits_per_word < 4)
> - || ((bits_per_word > 16) && (bits_per_word != 32)))
> + || ((bits_per_word > 16) && (bits_per_word != 32))
> + || (bits_per_word > mpc8xxx_spi->max_bits_per_word))
> return -EINVAL;

...we do have support for this in the core now, it would be good to
convert over to that.


Attachments:
(No filename) (646.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments

2013-04-09 17:02:18

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v3 5/7] spi: spi-fsl-spi: Add support for setting a maximum number of bits per word

On Tue, Apr 09, 2013 at 05:57:38PM +0100, Mark Brown wrote:
> On Fri, Feb 15, 2013 at 04:52:25PM +0100, Andreas Larsson wrote:
> > Acked-by: Anton Vorontsov <[email protected]>
> > Signed-off-by: Andreas Larsson <[email protected]>

> I'll apply this on account of it being part of the series and review
> having been very slow but...

...actually it turns out Grant already applied this anyway and I missed
it somehow - sorry for the noise!


Attachments:
(No filename) (443.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments