Cc: Mark
On 09.04.2013 18:40, Josef Ahmad wrote:
> spi_bitbang_setup() deasserts the chip select line to initialise
> the device. The chip select GPIO line is obtained from
> spi_gpio->cs_gpios[] private data.
> Currently, devices that are not registered under devicetree
> environment will call into spi_bitbang_setup() with stale
> cs_gpios[].
>
> This patch ensures spi_gpio->cs_gpios[] is always initialised prior
> to calling spi_bitbang_setup().
>
> Reviewed-by: Daniel Mack <[email protected]>
> Signed-off-by: Josef Ahmad <[email protected]>
> ---
> drivers/spi/spi-gpio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c
> index c7cf0b7..0fa345c 100644
> --- a/drivers/spi/spi-gpio.c
> +++ b/drivers/spi/spi-gpio.c
> @@ -265,9 +265,9 @@ static int spi_gpio_setup(struct spi_device *spi)
> }
> }
> if (!status) {
> - status = spi_bitbang_setup(spi);
> /* in case it was initialized from static board data */
> spi_gpio->cs_gpios[spi->chip_select] = cs;
> + status = spi_bitbang_setup(spi);
> }
>
> if (status) {
>
On Tue, Apr 09, 2013 at 07:06:32PM +0200, Daniel Mack wrote:
> Cc: Mark
>
> On 09.04.2013 18:40, Josef Ahmad wrote:
> > spi_bitbang_setup() deasserts the chip select line to initialise
> > the device. The chip select GPIO line is obtained from
Please resend the patch - git am doesn't know how to strip off quotation
stuff!
On 09.04.2013 19:08, Mark Brown wrote:
> On Tue, Apr 09, 2013 at 07:06:32PM +0200, Daniel Mack wrote:
>> Cc: Mark
>>
>> On 09.04.2013 18:40, Josef Ahmad wrote:
>>> spi_bitbang_setup() deasserts the chip select line to initialise
>>> the device. The chip select GPIO line is obtained from
>
> Please resend the patch - git am doesn't know how to strip off quotation
> stuff!
>
The reply was fyi only, as the patch also went to spi-devel-general. Can
you pick it from there or should Josef send it again with your address
in Cc:?
On Tue, Apr 09, 2013 at 07:11:21PM +0200, Daniel Mack wrote:
> The reply was fyi only, as the patch also went to spi-devel-general. Can
> you pick it from there or should Josef send it again with your address
> in Cc:?
Please make sure stuff goes to my inbox, I *can* pick up from
-devel-general but it's generally painful as my list traffic is going to
a different e-mail account and so on (plus I'm heavily backlogged on
list traffic in general at the minute, and sourceforge is full of spam).