2013-04-15 07:00:34

by Sebastian Hesselbarth

[permalink] [raw]
Subject: [PATCH] clk: si5351: make clk-si5351 depend on CONFIG_OF

Calling clk-si5351 driver non-OF ready was too early. This patch
makes clk-si5351 depend on CONFIG_OF again, until things get sorted out.

Signed-off-by: Sebastian Hesselbarth <[email protected]>
Reported-by: Stephen Rottweil <[email protected]>
---
Cc: Stephen Rothwell <[email protected]>
Cc: Grant Likely <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Rob Landley <[email protected]>
Cc: Mike Turquette <[email protected]>
Cc: Stephen Warren <[email protected]>
Cc: Thierry Reding <[email protected]>
Cc: Dom Cobley <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Pawel Moll <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Russell King - ARM Linux <[email protected]>
Cc: Rabeeh Khoury <[email protected]>
Cc: Daniel Mack <[email protected]>
Cc: Jean-Francois Moine <[email protected]>
Cc: Lars-Peter Clausen <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Michal Bachraty <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
drivers/clk/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 5039e41..6412f55 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -58,6 +58,7 @@ config COMMON_CLK_MAX77686
config COMMON_CLK_SI5351
tristate "Clock driver for SiLabs 5351A/B/C"
depends on I2C
+ depends on OF
select REGMAP_I2C
select RATIONAL
---help---
--
1.7.10.4


2013-04-16 00:55:36

by Stephen Rothwell

[permalink] [raw]
Subject: Re: [PATCH] clk: si5351: make clk-si5351 depend on CONFIG_OF

Hi Sebastian,

On Mon, 15 Apr 2013 09:00:14 +0200 Sebastian Hesselbarth <[email protected]> wrote:
>
> Calling clk-si5351 driver non-OF ready was too early. This patch
> makes clk-si5351 depend on CONFIG_OF again, until things get sorted out.
>
> Signed-off-by: Sebastian Hesselbarth <[email protected]>
> Reported-by: Stephen Rottweil <[email protected]>

My name is spelt "Rothwell" (as in the Cc: line below) :-(

> ---
> Cc: Stephen Rothwell <[email protected]>

--
Cheers,
Stephen Rothwell [email protected]

Attachments:
(No filename) (571.00 B)
 (No filename) (836.00 B)
 Download all attachments

2013-04-16 04:46:02

by Mike Turquette

[permalink] [raw]
Subject: Re: [PATCH] clk: si5351: make clk-si5351 depend on CONFIG_OF

Quoting Stephen Rothwell (2013-04-15 17:55:13)
> Hi Sebastian,
>
> On Mon, 15 Apr 2013 09:00:14 +0200 Sebastian Hesselbarth <[email protected]> wrote:
> >
> > Calling clk-si5351 driver non-OF ready was too early. This patch
> > makes clk-si5351 depend on CONFIG_OF again, until things get sorted out.
> >
> > Signed-off-by: Sebastian Hesselbarth <[email protected]>
> > Reported-by: Stephen Rottweil <[email protected]>
>
> My name is spelt "Rothwell" (as in the Cc: line below) :-(
>

It's fixed in the merged version.

Regards,
Mike

> > ---
> > Cc: Stephen Rothwell <[email protected]>
>
> --
> Cheers,
> Stephen Rothwell [email protected]