2013-04-16 08:55:00

by Michal Marek

Subject: [PATCH] input: Export matrix_keypad_parse_of_params()

Couple of input drivers depend on this symbol:

ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/tca8418_keypad.ko] undefined!
ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/cros_ec_keyb.ko] undefined!

Reported-by: Randy Dunlap <[email protected]>
Acked-by: Dmitry Torokhov <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
---
drivers/input/matrix-keymap.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/input/matrix-keymap.c b/drivers/input/matrix-keymap.c
index 619b382..08b61f5 100644
--- a/drivers/input/matrix-keymap.c
+++ b/drivers/input/matrix-keymap.c
@@ -68,6 +68,7 @@ int matrix_keypad_parse_of_params(struct device *dev,

return 0;
}
+EXPORT_SYMBOL_GPL(matrix_keypad_parse_of_params);

static int matrix_keypad_parse_of_keymap(const char *propname,
unsigned int rows, unsigned int cols,
--
1.8.2.1

2013-04-17 17:54:18

by Randy Dunlap

Subject: Re: [PATCH] input: Export matrix_keypad_parse_of_params()

On 04/16/13 01:50, Michal Marek wrote:
> Couple of input drivers depend on this symbol:
>
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/tca8418_keypad.ko] undefined!
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/cros_ec_keyb.ko] undefined!
>
> Reported-by: Randy Dunlap <[email protected]>
> Acked-by: Dmitry Torokhov <[email protected]>
> Signed-off-by: Michal Marek <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> drivers/input/matrix-keymap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/matrix-keymap.c b/drivers/input/matrix-keymap.c
> index 619b382..08b61f5 100644
> --- a/drivers/input/matrix-keymap.c
> +++ b/drivers/input/matrix-keymap.c
> @@ -68,6 +68,7 @@ int matrix_keypad_parse_of_params(struct device *dev,
>
> return 0;
> }
> +EXPORT_SYMBOL_GPL(matrix_keypad_parse_of_params);
>
> static int matrix_keypad_parse_of_keymap(const char *propname,
> unsigned int rows, unsigned int cols,
>


--
~Randy

2013-04-17 18:11:36

by Simon Glass

Subject: Re: [PATCH] input: Export matrix_keypad_parse_of_params()

On Tue, Apr 16, 2013 at 1:50 AM, Michal Marek <[email protected]> wrote:
> Couple of input drivers depend on this symbol:
>
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/tca8418_keypad.ko] undefined!
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/cros_ec_keyb.ko] undefined!
>
> Reported-by: Randy Dunlap <[email protected]>
> Acked-by: Dmitry Torokhov <[email protected]>
> Signed-off-by: Michal Marek <[email protected]>

Acked-by: Simon Glass <[email protected]>

2013-04-18 22:32:08

by Samuel Ortiz

Subject: Re: [PATCH] input: Export matrix_keypad_parse_of_params()

Hi Marek,

On Tue, Apr 16, 2013 at 10:50:54AM +0200, Michal Marek wrote:
> Couple of input drivers depend on this symbol:
>
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/tca8418_keypad.ko] undefined!
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/cros_ec_keyb.ko] undefined!
>
> Reported-by: Randy Dunlap <[email protected]>
> Acked-by: Dmitry Torokhov <[email protected]>
> Signed-off-by: Michal Marek <[email protected]>
> ---
> drivers/input/matrix-keymap.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/