2013-04-23 14:43:27

by Thorsten Glaser

[permalink] [raw]
Subject: [PATCH] update AMD powerflags comments

from http://www.flounder.com/cpuid80000007amd.gif
and http://support.amd.com/us/Embedded_TechDocs/25481.pdf

Signed-off-by: Thorsten Glaser <[email protected]>
---
arch/x86/kernel/cpu/powerflags.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/cpu/powerflags.c b/arch/x86/kernel/cpu/powerflags.c
index 7b3fe56..31f0f33 100644
--- a/arch/x86/kernel/cpu/powerflags.c
+++ b/arch/x86/kernel/cpu/powerflags.c
@@ -11,10 +11,10 @@ const char *const x86_power_flags[32] = {
"fid", /* frequency id control */
"vid", /* voltage id control */
"ttp", /* thermal trip */
- "tm",
- "stc",
- "100mhzsteps",
- "hwpstate",
+ "tm", /* hardware thermal control */
+ "stc", /* software thermal control */
+ "100mhzsteps", /* 100 MHz multiplier control */
+ "hwpstate", /* hardware P-state control */
"", /* tsc invariant mapped to constant_tsc */
"cpb", /* core performance boost */
"eff_freq_ro", /* Readonly aperf/mperf */
--
1.7.9


2013-04-23 14:49:41

by Thorsten Glaser

[permalink] [raw]
Subject: Re: [PATCH] update AMD powerflags comments

Dixi quod…

>+ "100mhzsteps", /* 100 MHz multiplier control */
>+ "hwpstate", /* hardware P-state control */
> "", /* tsc invariant mapped to constant_tsc */

Are patches to correct the indentation style desired?
I’d just put in two tabs (one after the longer texts)
myself…

(In case someone wonders, we were comparing server boxen
at work today, and nobody seemed to know what stc was; a
suggestion was “stable clock” since the box with*out* it
had clock stability issues with full-virtualised guests,
the other didn’t… turns out that was not it.)

bye,
//mirabilos
--
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-314
HRB AG Bonn 5168 • USt-ID (VAT): DE122264941
Geschäftsführer: Boris Esser, Sebastian Mancke