2013-04-25 20:31:46

by Thomas Gleixner

[permalink] [raw]
Subject: [patch 01/15] clocksource: apb_timer: Remove unsused function

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Jamie Iles <[email protected]>
---
drivers/clocksource/dw_apb_timer.c | 12 ------------
include/linux/dw_apb_timer.h | 1 -
2 files changed, 13 deletions(-)

Index: tip/drivers/clocksource/dw_apb_timer.c
===================================================================
--- tip.orig/drivers/clocksource/dw_apb_timer.c
+++ tip/drivers/clocksource/dw_apb_timer.c
@@ -387,15 +387,3 @@ cycle_t dw_apb_clocksource_read(struct d
{
return (cycle_t)~apbt_readl(&dw_cs->timer, APBTMR_N_CURRENT_VALUE);
}
-
-/**
- * dw_apb_clocksource_unregister() - unregister and free a clocksource.
- *
- * @dw_cs: The clocksource to unregister/free.
- */
-void dw_apb_clocksource_unregister(struct dw_apb_clocksource *dw_cs)
-{
- clocksource_unregister(&dw_cs->cs);
-
- kfree(dw_cs);
-}
Index: tip/include/linux/dw_apb_timer.h
===================================================================
--- tip.orig/include/linux/dw_apb_timer.h
+++ tip/include/linux/dw_apb_timer.h
@@ -51,7 +51,6 @@ dw_apb_clocksource_init(unsigned rating,
void dw_apb_clocksource_register(struct dw_apb_clocksource *dw_cs);
void dw_apb_clocksource_start(struct dw_apb_clocksource *dw_cs);
cycle_t dw_apb_clocksource_read(struct dw_apb_clocksource *dw_cs);
-void dw_apb_clocksource_unregister(struct dw_apb_clocksource *dw_cs);

extern void dw_apb_timer_init(void);
#endif /* __DW_APB_TIMER_H__ */


2013-04-26 12:43:28

by Jamie Iles

[permalink] [raw]
Subject: Re: [patch 01/15] clocksource: apb_timer: Remove unsused function

Hi Thomas,

On Thu, Apr 25, 2013 at 08:31:43PM -0000, Thomas Gleixner wrote:
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Jamie Iles <[email protected]>

Looks good, thanks for fixing this.

Acked-by: Jamie Iles <[email protected]>

2013-04-30 00:32:56

by John Stultz

[permalink] [raw]
Subject: Re: [patch 01/15] clocksource: apb_timer: Remove unsused function

On 04/25/2013 01:31 PM, Thomas Gleixner wrote:
> Signed-off-by: Thomas Gleixner<[email protected]>
> Cc: Jamie Iles<[email protected]>

Acked-by: John Stultz <[email protected]>

thanks
-john


> ---
> drivers/clocksource/dw_apb_timer.c | 12 ------------
> include/linux/dw_apb_timer.h | 1 -
> 2 files changed, 13 deletions(-)
>
> Index: tip/drivers/clocksource/dw_apb_timer.c
> ===================================================================
> --- tip.orig/drivers/clocksource/dw_apb_timer.c
> +++ tip/drivers/clocksource/dw_apb_timer.c
> @@ -387,15 +387,3 @@ cycle_t dw_apb_clocksource_read(struct d
> {
> return (cycle_t)~apbt_readl(&dw_cs->timer, APBTMR_N_CURRENT_VALUE);
> }
> -
> -/**
> - * dw_apb_clocksource_unregister() - unregister and free a clocksource.
> - *
> - * @dw_cs: The clocksource to unregister/free.
> - */
> -void dw_apb_clocksource_unregister(struct dw_apb_clocksource *dw_cs)
> -{
> - clocksource_unregister(&dw_cs->cs);
> -
> - kfree(dw_cs);
> -}
> Index: tip/include/linux/dw_apb_timer.h
> ===================================================================
> --- tip.orig/include/linux/dw_apb_timer.h
> +++ tip/include/linux/dw_apb_timer.h
> @@ -51,7 +51,6 @@ dw_apb_clocksource_init(unsigned rating,
> void dw_apb_clocksource_register(struct dw_apb_clocksource *dw_cs);
> void dw_apb_clocksource_start(struct dw_apb_clocksource *dw_cs);
> cycle_t dw_apb_clocksource_read(struct dw_apb_clocksource *dw_cs);
> -void dw_apb_clocksource_unregister(struct dw_apb_clocksource *dw_cs);
>
> extern void dw_apb_timer_init(void);
> #endif /* __DW_APB_TIMER_H__ */
>
>

Subject: [tip:timers/core] clocksource: apb_timer: Remove unsused function

Commit-ID: fc1f7d5606487ae28d6c84e95401952927d7379e
Gitweb: http://git.kernel.org/tip/fc1f7d5606487ae28d6c84e95401952927d7379e
Author: Thomas Gleixner <[email protected]>
AuthorDate: Thu, 25 Apr 2013 20:31:43 +0000
Committer: Thomas Gleixner <[email protected]>
CommitDate: Thu, 16 May 2013 11:09:13 +0200

clocksource: apb_timer: Remove unsused function

Signed-off-by: Thomas Gleixner <[email protected]>
Acked-by: John Stultz <[email protected]>
Cc: Magnus Damm <[email protected]>
Acked-by: Jamie Iles <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>
---
drivers/clocksource/dw_apb_timer.c | 12 ------------
include/linux/dw_apb_timer.h | 1 -
2 files changed, 13 deletions(-)

diff --git a/drivers/clocksource/dw_apb_timer.c b/drivers/clocksource/dw_apb_timer.c
index 8c2a35f..e54ca10 100644
--- a/drivers/clocksource/dw_apb_timer.c
+++ b/drivers/clocksource/dw_apb_timer.c
@@ -387,15 +387,3 @@ cycle_t dw_apb_clocksource_read(struct dw_apb_clocksource *dw_cs)
{
return (cycle_t)~apbt_readl(&dw_cs->timer, APBTMR_N_CURRENT_VALUE);
}
-
-/**
- * dw_apb_clocksource_unregister() - unregister and free a clocksource.
- *
- * @dw_cs: The clocksource to unregister/free.
- */
-void dw_apb_clocksource_unregister(struct dw_apb_clocksource *dw_cs)
-{
- clocksource_unregister(&dw_cs->cs);
-
- kfree(dw_cs);
-}
diff --git a/include/linux/dw_apb_timer.h b/include/linux/dw_apb_timer.h
index dd755ce..b1cd959 100644
--- a/include/linux/dw_apb_timer.h
+++ b/include/linux/dw_apb_timer.h
@@ -51,7 +51,6 @@ dw_apb_clocksource_init(unsigned rating, const char *name, void __iomem *base,
void dw_apb_clocksource_register(struct dw_apb_clocksource *dw_cs);
void dw_apb_clocksource_start(struct dw_apb_clocksource *dw_cs);
cycle_t dw_apb_clocksource_read(struct dw_apb_clocksource *dw_cs);
-void dw_apb_clocksource_unregister(struct dw_apb_clocksource *dw_cs);

extern void dw_apb_timer_init(void);
#endif /* __DW_APB_TIMER_H__ */