2013-05-03 06:24:27

by Jingoo Han

Subject: [PATCH 04/42] rtc: rtc-ab8500: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/rtc/rtc-ab8500.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
index 63cfa31..c5b62d4 100644
--- a/drivers/rtc/rtc-ab8500.c
+++ b/drivers/rtc/rtc-ab8500.c
@@ -451,8 +451,6 @@ static int ab8500_rtc_remove(struct platform_device *pdev)
{
ab8500_sysfs_rtc_unregister(&pdev->dev);

- platform_set_drvdata(pdev, NULL);
-
return 0;
}

--
1.7.2.5

2013-05-03 06:58:36

by Srinidhi Kasagar

Subject: Re: [PATCH 04/42] rtc: rtc-ab8500: remove unnecessary platform_set_drvdata()

On Fri, May 03, 2013 at 08:24:24 +0200, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <[email protected]>
> ---
> drivers/rtc/rtc-ab8500.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
> index 63cfa31..c5b62d4 100644
> --- a/drivers/rtc/rtc-ab8500.c
> +++ b/drivers/rtc/rtc-ab8500.c
> @@ -451,8 +451,6 @@ static int ab8500_rtc_remove(struct platform_device *pdev)
> {
> ab8500_sysfs_rtc_unregister(&pdev->dev);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
Ok, thanks. Hope you have taken care for the ab3100 too...

Acked-by:srinidhi kasagar <[email protected]>

regards/srinidhi

2013-05-03 07:36:01

by Jingoo Han

Subject: Re: [PATCH 04/42] rtc: rtc-ab8500: remove unnecessary platform_set_drvdata()

On Friday, May 03, 2013 3:58 PM, Srinidhi Kasagar wrote:
> On Fri, May 03, 2013 at 08:24:24 +0200, Jingoo Han wrote:
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> > (device-core: Ensure drvdata = NULL when no driver is bound).
> > Thus, it is not needed to manually clear the device driver data to NULL.
> >
> > Signed-off-by: Jingoo Han <[email protected]>
> > ---
> > drivers/rtc/rtc-ab8500.c | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
> > index 63cfa31..c5b62d4 100644
> > --- a/drivers/rtc/rtc-ab8500.c
> > +++ b/drivers/rtc/rtc-ab8500.c
> > @@ -451,8 +451,6 @@ static int ab8500_rtc_remove(struct platform_device *pdev)
> > {
> > ab8500_sysfs_rtc_unregister(&pdev->dev);
> >
> > - platform_set_drvdata(pdev, NULL);
> > -
> > return 0;
> > }
> Ok, thanks. Hope you have taken care for the ab3100 too...
>
> Acked-by:srinidhi kasagar <[email protected]>

Hi Srinidhi Kasagar,

I have already modified the ab3100 RTC driver as below:
(http://www.mail-archive.com/[email protected]/msg428126.html)

Thank you for your Acked-by. :)

Best regards,
Jingoo Han

>
> regards/srinidhi