2013-05-03 01:51:01

by Jonghwan Choi

Subject: [PATCH] virtio_blk: Add missing 'static' qualifiers

Add missing 'static' qualifiers

Signed-off-by: Jonghwan Choi <[email protected]>
---
drivers/block/virtio_blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 6472395..5cdf88b 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -20,7 +20,7 @@ module_param(use_bio, bool, S_IRUGO);
static int major;
static DEFINE_IDA(vd_index_ida);

-struct workqueue_struct *virtblk_wq;
+static struct workqueue_struct *virtblk_wq;

struct virtio_blk
{
--
1.7.9.5

2013-05-05 13:34:48

by Michael S. Tsirkin

Subject: Re: [PATCH] virtio_blk: Add missing 'static' qualifiers

On Fri, May 03, 2013 at 10:50:55AM +0900, Jonghwan Choi wrote:
> Add missing 'static' qualifiers
>
> Signed-off-by: Jonghwan Choi <[email protected]>

Acked-by: Michael S. Tsirkin <[email protected]>

> ---
> drivers/block/virtio_blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index 6472395..5cdf88b 100644
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -20,7 +20,7 @@ module_param(use_bio, bool, S_IRUGO);
> static int major;
> static DEFINE_IDA(vd_index_ida);
>
> -struct workqueue_struct *virtblk_wq;
> +static struct workqueue_struct *virtblk_wq;
>
> struct virtio_blk
> {
> --
> 1.7.9.5

2013-05-06 07:54:41

by Rusty Russell

Subject: Re: [PATCH] virtio_blk: Add missing 'static' qualifiers

"Michael S. Tsirkin" <[email protected]> writes:
> On Fri, May 03, 2013 at 10:50:55AM +0900, Jonghwan Choi wrote:
>> Add missing 'static' qualifiers
>>
>> Signed-off-by: Jonghwan Choi <[email protected]>
>
> Acked-by: Michael S. Tsirkin <[email protected]>

Applied.

Thanks,
Rusty.

>> ---
>> drivers/block/virtio_blk.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
>> index 6472395..5cdf88b 100644
>> --- a/drivers/block/virtio_blk.c
>> +++ b/drivers/block/virtio_blk.c
>> @@ -20,7 +20,7 @@ module_param(use_bio, bool, S_IRUGO);
>> static int major;
>> static DEFINE_IDA(vd_index_ida);
>>
>> -struct workqueue_struct *virtblk_wq;
>> +static struct workqueue_struct *virtblk_wq;
>>
>> struct virtio_blk
>> {
>> --
>> 1.7.9.5