2013-04-19 12:06:15

by Michal Marek

Subject: [PATCH] mfd: MFD_TPS65912 needs MFD_CORE

With MFD_TPS65912=y and MFD_CORE=m/n, the build fails with

drivers/mfd/tps65912-core.c:147: undefined reference to `mfd_add_devices'
drivers/mfd/tps65912-core.c:164: undefined reference to `mfd_remove_devices'
drivers/mfd/tps65912-core.c:171: undefined reference to `mfd_remove_devices'

Signed-off-by: Michal Marek <[email protected]>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 60611cd..5faf7c2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -805,6 +805,7 @@ config MFD_TPS65910
config MFD_TPS65912
bool "TI TPS65912 Power Management chip"
depends on GPIOLIB
+ select MFD_CORE
help
If you say yes here you get support for the TPS65912 series of
PM chips.
--
1.8.2.1

2013-05-07 21:39:56

by Borislav Petkov

Subject: Re: [PATCH] mfd: MFD_TPS65912 needs MFD_CORE

On Fri, Apr 19, 2013 at 02:05:56PM +0200, Michal Marek wrote:
> With MFD_TPS65912=y and MFD_CORE=m/n, the build fails with
>
> drivers/mfd/tps65912-core.c:147: undefined reference to `mfd_add_devices'
> drivers/mfd/tps65912-core.c:164: undefined reference to `mfd_remove_devices'
> drivers/mfd/tps65912-core.c:171: undefined reference to `mfd_remove_devices'
>
> Signed-off-by: Michal Marek <[email protected]>

Acked-by: Borislav Petkov <[email protected]>

Looks like this one is not upstream yet - just triggered it on a
randconfig build of current linus.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

2013-05-16 22:13:46

by Samuel Ortiz

Subject: Re: [PATCH] mfd: MFD_TPS65912 needs MFD_CORE

Hi Marek,

On Fri, Apr 19, 2013 at 02:05:56PM +0200, Michal Marek wrote:
> With MFD_TPS65912=y and MFD_CORE=m/n, the build fails with
>
> drivers/mfd/tps65912-core.c:147: undefined reference to `mfd_add_devices'
> drivers/mfd/tps65912-core.c:164: undefined reference to `mfd_remove_devices'
> drivers/mfd/tps65912-core.c:171: undefined reference to `mfd_remove_devices'
>
> Signed-off-by: Michal Marek <[email protected]>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
This one is on my mfd-fixes tree already, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/