2013-04-17 21:28:51

by David Rientjes

Subject: [patch] drivers, mfd: fix tps65912 link error when core mfd is a module

CONFIG_MFD_CORE must be statically linked if CONFIG_MFD_TPS65912 is
selected, otherwise it results in a link error:

drivers/built-in.o: In function `tps65912_device_init':
(.text+0x587e4): undefined reference to `mfd_add_devices'
drivers/built-in.o: In function `tps65912_device_init':
(.text+0x5884c): undefined reference to `mfd_remove_devices'
drivers/built-in.o: In function `tps65912_device_exit':
(.text+0x58878): undefined reference to `mfd_remove_devices'

Signed-off-by: David Rientjes <[email protected]>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -805,6 +805,7 @@ config MFD_TPS65910
config MFD_TPS65912
bool "TI TPS65912 Power Management chip"
depends on GPIOLIB
+ select MFD_CORE
help
If you say yes here you get support for the TPS65912 series of
PM chips.

2013-05-16 22:13:10

by Samuel Ortiz

Subject: Re: [patch] drivers, mfd: fix tps65912 link error when core mfd is a module

Hi David,

On Wed, Apr 17, 2013 at 02:28:47PM -0700, David Rientjes wrote:
> CONFIG_MFD_CORE must be statically linked if CONFIG_MFD_TPS65912 is
> selected, otherwise it results in a link error:
>
> drivers/built-in.o: In function `tps65912_device_init':
> (.text+0x587e4): undefined reference to `mfd_add_devices'
> drivers/built-in.o: In function `tps65912_device_init':
> (.text+0x5884c): undefined reference to `mfd_remove_devices'
> drivers/built-in.o: In function `tps65912_device_exit':
> (.text+0x58878): undefined reference to `mfd_remove_devices'
>
> Signed-off-by: David Rientjes <[email protected]>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied to mfd-fixes, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/