After cancelling all reads from the disable hook, we need to reset the
event_cb pointer as well or else we won't be able to set a new one up
when re-enabling the device.
Signed-off-by: Samuel Ortiz <[email protected]>
---
drivers/misc/mei/bus.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index 1e935ea..9ecd49a 100644
--- a/drivers/misc/mei/bus.c
+++ b/drivers/misc/mei/bus.c
@@ -496,6 +496,8 @@ int mei_cl_disable_device(struct mei_cl_device *device)
}
}
+ device->event_cb = NULL;
+
mutex_unlock(&dev->device_lock);
if (!device->ops || !device->ops->disable)
--
1.7.10.4
--
Intel Open Source Technology Centre
http://oss.intel.com/
> -----Original Message-----
> From: Samuel Ortiz [mailto:[email protected]]
> Sent: Tuesday, May 21, 2013 16:58
> To: Winkler, Tomas
> Cc: linux-kernel
> Subject: [PATCH] [3.10] mei: bus: Reset event_cb when disabling a device
>
> After cancelling all reads from the disable hook, we need to reset the
> event_cb pointer as well or else we won't be able to set a new one up when
> re-enabling the device.
>
> Signed-off-by: Samuel Ortiz <[email protected]>
Acked.
On Tue, May 21, 2013 at 03:01:27PM +0000, Winkler, Tomas wrote:
>
>
> > -----Original Message-----
> > From: Samuel Ortiz [mailto:[email protected]]
> > Sent: Tuesday, May 21, 2013 16:58
> > To: Winkler, Tomas
> > Cc: linux-kernel
> > Subject: [PATCH] [3.10] mei: bus: Reset event_cb when disabling a device
> >
> > After cancelling all reads from the disable hook, we need to reset the
> > event_cb pointer as well or else we won't be able to set a new one up when
> > re-enabling the device.
> >
> > Signed-off-by: Samuel Ortiz <[email protected]>
> Acked.
Greg, I did not initially Cc you and now you don't actually have the patch,
sorry.
Let me re-send the patch with Tomas ACK added.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
On Tue, May 21, 2013 at 03:01:27PM +0000, Winkler, Tomas wrote:
>
>
> > -----Original Message-----
> > From: Samuel Ortiz [mailto:[email protected]]
> > Sent: Tuesday, May 21, 2013 16:58
> > To: Winkler, Tomas
> > Cc: linux-kernel
> > Subject: [PATCH] [3.10] mei: bus: Reset event_cb when disabling a device
> >
> > After cancelling all reads from the disable hook, we need to reset the
> > event_cb pointer as well or else we won't be able to set a new one up when
> > re-enabling the device.
> >
> > Signed-off-by: Samuel Ortiz <[email protected]>
> Acked.
Nice, but can someone actually send me the patch to apply?
thanks,
greg k-h