Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for handling pinctrl.
So remove devm_pinctrl_get_select_default() from the driver.
Cc: Thierry Reding <[email protected]>
Cc: <[email protected]>
Signed-off-by: Fabio Estevam <[email protected]>
---
drivers/pwm/pwm-mxs.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
index a53d309..7dd6544 100644
--- a/drivers/pwm/pwm-mxs.c
+++ b/drivers/pwm/pwm-mxs.c
@@ -16,7 +16,6 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_address.h>
-#include <linux/pinctrl/consumer.h>
#include <linux/platform_device.h>
#include <linux/pwm.h>
#include <linux/slab.h>
@@ -131,7 +130,6 @@ static int mxs_pwm_probe(struct platform_device *pdev)
struct device_node *np = pdev->dev.of_node;
struct mxs_pwm_chip *mxs;
struct resource *res;
- struct pinctrl *pinctrl;
int ret;
mxs = devm_kzalloc(&pdev->dev, sizeof(*mxs), GFP_KERNEL);
@@ -143,10 +141,6 @@ static int mxs_pwm_probe(struct platform_device *pdev)
if (IS_ERR(mxs->base))
return PTR_ERR(mxs->base);
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl))
- return PTR_ERR(pinctrl);
-
mxs->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(mxs->clk))
return PTR_ERR(mxs->clk);
--
1.7.9.5
Fabio Estevam <[email protected]> writes:
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for handling pinctrl.
>
> So remove devm_pinctrl_get_select_default() from the driver.
>
> Cc: Thierry Reding <[email protected]>
> Cc: <[email protected]>
> Signed-off-by: Fabio Estevam <[email protected]>
> ---
> drivers/pwm/pwm-mxs.c | 6 ------
> 1 file changed, 6 deletions(-)
Looks good, can we have some tested-by from imx guys?
Regards,
--
Alex
On Wed, May 08, 2013 at 02:51:33PM +0300, Alexander Shishkin wrote:
> Fabio Estevam <[email protected]> writes:
>
> > Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> > we can rely on device core for handling pinctrl.
> >
> > So remove devm_pinctrl_get_select_default() from the driver.
> >
> > Cc: Thierry Reding <[email protected]>
> > Cc: <[email protected]>
> > Signed-off-by: Fabio Estevam <[email protected]>
> > ---
> > drivers/pwm/pwm-mxs.c | 6 ------
> > 1 file changed, 6 deletions(-)
>
> Looks good, can we have some tested-by from imx guys?
I'm not sure why you're interested in this patch instead of
"[PATCH 01/13] usb: chipidea: ci13xxx_imx: Let device core handle
pinctrl". I tested both patches, so
Tested-by: Shawn Guo <[email protected]>
Shawn Guo <[email protected]> writes:
> On Wed, May 08, 2013 at 02:51:33PM +0300, Alexander Shishkin wrote:
>> Fabio Estevam <[email protected]> writes:
>>
>> > Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
>> > we can rely on device core for handling pinctrl.
>> >
>> > So remove devm_pinctrl_get_select_default() from the driver.
>> >
>> > Cc: Thierry Reding <[email protected]>
>> > Cc: <[email protected]>
>> > Signed-off-by: Fabio Estevam <[email protected]>
>> > ---
>> > drivers/pwm/pwm-mxs.c | 6 ------
>> > 1 file changed, 6 deletions(-)
>>
>> Looks good, can we have some tested-by from imx guys?
>
> I'm not sure why you're interested in this patch instead of
> "[PATCH 01/13] usb: chipidea: ci13xxx_imx: Let device core handle
> pinctrl". I tested both patches, so
I don't seem to have this one in either of my mailboxes.
> Tested-by: Shawn Guo <[email protected]>
Thank you.
Alexander Shishkin <[email protected]> writes:
> Shawn Guo <[email protected]> writes:
>
>> On Wed, May 08, 2013 at 02:51:33PM +0300, Alexander Shishkin wrote:
>>> Fabio Estevam <[email protected]> writes:
>>>
>>> > Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
>>> > we can rely on device core for handling pinctrl.
>>> >
>>> > So remove devm_pinctrl_get_select_default() from the driver.
>>> >
>>> > Cc: Thierry Reding <[email protected]>
>>> > Cc: <[email protected]>
>>> > Signed-off-by: Fabio Estevam <[email protected]>
>>> > ---
>>> > drivers/pwm/pwm-mxs.c | 6 ------
>>> > 1 file changed, 6 deletions(-)
>>>
>>> Looks good, can we have some tested-by from imx guys?
>>
>> I'm not sure why you're interested in this patch instead of
>> "[PATCH 01/13] usb: chipidea: ci13xxx_imx: Let device core handle
>> pinctrl". I tested both patches, so
>
> I don't seem to have this one in either of my mailboxes.
Please disregard this. :)
Thanks,
--
Alex
Hi Thierry,
On Mon, May 6, 2013 at 3:05 PM, Fabio Estevam
<[email protected]> wrote:
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for handling pinctrl.
>
> So remove devm_pinctrl_get_select_default() from the driver.
>
> Cc: Thierry Reding <[email protected]>
> Cc: <[email protected]>
> Signed-off-by: Fabio Estevam <[email protected]>
Any comments on this one?
On Sun, May 26, 2013 at 06:02:16PM -0300, Fabio Estevam wrote:
> Hi Thierry,
>
> On Mon, May 6, 2013 at 3:05 PM, Fabio Estevam
> <[email protected]> wrote:
> > Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> > we can rely on device core for handling pinctrl.
> >
> > So remove devm_pinctrl_get_select_default() from the driver.
> >
> > Cc: Thierry Reding <[email protected]>
> > Cc: <[email protected]>
> > Signed-off-by: Fabio Estevam <[email protected]>
>
> Any comments on this one?
Looks good. I've applied it to my for-next branch. Thanks for pinging
me.
Thierry