2013-05-24 20:01:20

by Fabio Estevam

Subject: [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate

From: Fabio Estevam <[email protected]>

Fix the following sparse warning:

drivers/dma/mxs-dma.c:696:17: warning: symbol 'mxs_dma_xlate' was not declared. Should it be static?

Signed-off-by: Fabio Estevam <[email protected]>
---
drivers/dma/mxs-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index b48a79c..7195930 100644
--- a/drivers/dma/mxs-dma.c
+++ b/drivers/dma/mxs-dma.c
@@ -693,7 +693,7 @@ static bool mxs_dma_filter_fn(struct dma_chan *chan, void *fn_param)
return true;
}

-struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
+static struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
struct of_dma *ofdma)
{
struct mxs_dma_engine *mxs_dma = ofdma->of_dma_data;
--
1.8.1.2

2013-05-27 07:07:23

by Shawn Guo

Subject: Re: [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate

On Fri, May 24, 2013 at 04:37:27PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <[email protected]>
>
> Fix the following sparse warning:
>
> drivers/dma/mxs-dma.c:696:17: warning: symbol 'mxs_dma_xlate' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <[email protected]>

Acked-by: Shawn Guo <[email protected]>

> ---
> drivers/dma/mxs-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index b48a79c..7195930 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -693,7 +693,7 @@ static bool mxs_dma_filter_fn(struct dma_chan *chan, void *fn_param)
> return true;
> }
>
> -struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
> +static struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
> struct of_dma *ofdma)
> {
> struct mxs_dma_engine *mxs_dma = ofdma->of_dma_data;
> --
> 1.8.1.2
>

2013-05-27 10:43:30

by Vinod Koul

Subject: Re: [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate

On Fri, May 24, 2013 at 04:37:27PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <[email protected]>
>
> Fix the following sparse warning:
>
> drivers/dma/mxs-dma.c:696:17: warning: symbol 'mxs_dma_xlate' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <[email protected]>
Applied, Thanks

--
~Vinod
> ---
> drivers/dma/mxs-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index b48a79c..7195930 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -693,7 +693,7 @@ static bool mxs_dma_filter_fn(struct dma_chan *chan, void *fn_param)
> return true;
> }
>
> -struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
> +static struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
> struct of_dma *ofdma)
> {
> struct mxs_dma_engine *mxs_dma = ofdma->of_dma_data;
> --
> 1.8.1.2
>