2013-05-28 21:11:50

by Philip J. Kelleher

[permalink] [raw]
Subject: [PATCH 4/8] rsxx: Corrected discard support version number.

From: Philip J Kelleher <[email protected]>

Changing the Discard support version number to the correct
value.

Signed-off-by: Philip J Kelleher <[email protected]>
-------------------------------------------------------------------------------



diff -uprN -X linux-block-vanilla/Documentation/dontdiff linux-block-vanilla/drivers/block/rsxx/rsxx_priv.h linux-block/drivers/block/rsxx/rsxx_priv.h
--- linux-block-vanilla/drivers/block/rsxx/rsxx_priv.h 2013-05-01 18:36:44.698309293 -0500
+++ linux-block/drivers/block/rsxx/rsxx_priv.h 2013-05-01 18:37:56.277183367 -0500
@@ -273,7 +273,7 @@ enum rsxx_hw_fifo_flush {
};

enum rsxx_pci_revision {
- RSXX_DISCARD_SUPPORT = 2,
+ RSXX_DISCARD_SUPPORT = 4,
RSXX_EEH_SUPPORT = 3,
};


2013-05-29 18:20:20

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH 4/8] rsxx: Corrected discard support version number.

On Wed, May 29, 2013 at 12:11 AM, Philip J. Kelleher
<[email protected]> wrote:
> From: Philip J Kelleher <[email protected]>
>
> Changing the Discard support version number to the correct
> value.
>

> +++ linux-block/drivers/block/rsxx/rsxx_priv.h 2013-05-01 18:37:56.277183367 -0500
> @@ -273,7 +273,7 @@ enum rsxx_hw_fifo_flush {
> };
>
> enum rsxx_pci_revision {
> - RSXX_DISCARD_SUPPORT = 2,
> + RSXX_DISCARD_SUPPORT = 4,
> RSXX_EEH_SUPPORT = 3,

Shouldn't it be sorted from low to high?

--
With Best Regards,
Andy Shevchenko