2013-05-31 07:10:45

by Jean Delvare

Subject: [PATCH] There is no /sys/parameters

There is no such path as /sys/parameters, module parameters live in
/sys/module/*/parameters.

Signed-off-by: Jean Delvare <[email protected]>
Cc: Rusty Russell <[email protected]>
---
include/linux/moduleparam.h | 2 +-
kernel/params.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-3.10-rc3.orig/include/linux/moduleparam.h 2013-04-29 02:36:01.000000000 +0200
+++ linux-3.10-rc3/include/linux/moduleparam.h 2013-05-30 10:41:37.417314420 +0200
@@ -439,7 +439,7 @@ extern struct kernel_param_ops param_ops
extern int param_set_copystring(const char *val, const struct kernel_param *);
extern int param_get_string(char *buffer, const struct kernel_param *kp);

-/* for exporting parameters in /sys/parameters */
+/* for exporting parameters in /sys/module/.../parameters */

struct module;

--- linux-3.10-rc3.orig/kernel/params.c 2013-05-13 15:27:49.883223693 +0200
+++ linux-3.10-rc3/kernel/params.c 2013-05-30 10:43:40.411316243 +0200
@@ -787,7 +787,7 @@ static void __init kernel_add_sysfs_para
}

/*
- * param_sysfs_builtin - add contents in /sys/parameters for built-in modules
+ * param_sysfs_builtin - add sysfs parameters for built-in modules
*
* Add module_parameters to sysfs for "modules" built into the kernel.
*


--
Jean Delvare

2013-06-03 02:32:43

by Rusty Russell

Subject: Re: [PATCH] There is no /sys/parameters

Jean Delvare <[email protected]> writes:

> There is no such path as /sys/parameters, module parameters live in
> /sys/module/*/parameters.

Thanks, applied!

Cheers,
Rusty.

> Signed-off-by: Jean Delvare <[email protected]>
> Cc: Rusty Russell <[email protected]>
> ---
> include/linux/moduleparam.h | 2 +-
> kernel/params.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-3.10-rc3.orig/include/linux/moduleparam.h 2013-04-29 02:36:01.000000000 +0200
> +++ linux-3.10-rc3/include/linux/moduleparam.h 2013-05-30 10:41:37.417314420 +0200
> @@ -439,7 +439,7 @@ extern struct kernel_param_ops param_ops
> extern int param_set_copystring(const char *val, const struct kernel_param *);
> extern int param_get_string(char *buffer, const struct kernel_param *kp);
>
> -/* for exporting parameters in /sys/parameters */
> +/* for exporting parameters in /sys/module/.../parameters */
>
> struct module;
>
> --- linux-3.10-rc3.orig/kernel/params.c 2013-05-13 15:27:49.883223693 +0200
> +++ linux-3.10-rc3/kernel/params.c 2013-05-30 10:43:40.411316243 +0200
> @@ -787,7 +787,7 @@ static void __init kernel_add_sysfs_para
> }
>
> /*
> - * param_sysfs_builtin - add contents in /sys/parameters for built-in modules
> + * param_sysfs_builtin - add sysfs parameters for built-in modules
> *
> * Add module_parameters to sysfs for "modules" built into the kernel.
> *
>
>
> --
> Jean Delvare