2013-06-10 22:02:55

by Raphael S Carvalho

Subject: [PATCH 1/1] kernel/pid.c: Moving statement.

Moving statement to static initilization of init_pid_ns.

Signed-off-by: Raphael S. Carvalho <[email protected]>
---
kernel/pid.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/pid.c b/kernel/pid.c
index 0db3e79..c577d3c 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -75,6 +75,7 @@ struct pid_namespace init_pid_ns = {
[ 0 ... PIDMAP_ENTRIES-1] = { ATOMIC_INIT(BITS_PER_PAGE), NULL }
},
.last_pid = 0,
+ .nr_hashed = PIDNS_HASH_ADDING,
.level = 0,
.child_reaper = &init_task,
.user_ns = &init_user_ns,
@@ -594,7 +595,6 @@ void __init pidmap_init(void)
/* Reserve PID 0. We never call free_pidmap(0) */
set_bit(0, init_pid_ns.pidmap[0].page);
atomic_dec(&init_pid_ns.pidmap[0].nr_free);
- init_pid_ns.nr_hashed = PIDNS_HASH_ADDING;

init_pid_ns.pid_cachep = KMEM_CACHE(pid,
SLAB_HWCACHE_ALIGN | SLAB_PANIC);
--
1.7.2.5

2013-06-13 17:14:24

by Serge E. Hallyn

Subject: Re: [PATCH 1/1] kernel/pid.c: Moving statement.

Quoting Raphael S. Carvalho ([email protected]):
> Moving statement to static initilization of init_pid_ns.
>
> Signed-off-by: Raphael S. Carvalho <[email protected]>

This seems innocuous enough.

Acked-by: Serge Hallyn <[email protected]>

> ---
> kernel/pid.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/pid.c b/kernel/pid.c
> index 0db3e79..c577d3c 100644
> --- a/kernel/pid.c
> +++ b/kernel/pid.c
> @@ -75,6 +75,7 @@ struct pid_namespace init_pid_ns = {
> [ 0 ... PIDMAP_ENTRIES-1] = { ATOMIC_INIT(BITS_PER_PAGE), NULL }
> },
> .last_pid = 0,
> + .nr_hashed = PIDNS_HASH_ADDING,
> .level = 0,
> .child_reaper = &init_task,
> .user_ns = &init_user_ns,
> @@ -594,7 +595,6 @@ void __init pidmap_init(void)
> /* Reserve PID 0. We never call free_pidmap(0) */
> set_bit(0, init_pid_ns.pidmap[0].page);
> atomic_dec(&init_pid_ns.pidmap[0].nr_free);
> - init_pid_ns.nr_hashed = PIDNS_HASH_ADDING;
>
> init_pid_ns.pid_cachep = KMEM_CACHE(pid,
> SLAB_HWCACHE_ALIGN | SLAB_PANIC);
> --
> 1.7.2.5