From: J Keerthy <[email protected]>
The Patch series adds TPS659038 PMIC support in the palmas MFD and Regulator
drivers. The TPS659038 has almost the same registers as of the earlier
supported variants of PALMAS family such as the TWL6035.
The critical differences between TPS659038 and TWL6035 being:
1) TPS659038 has nothing related to battery charging and back up battery stuff.
2) TPS659038 does not have does not have SMPS10(Boost) step up convertor.
3) TPS659038 does not have Battery detection and anything related to battery.
4) SD card detection, Battery presence detection, Vibrator, USB OTG are missing
when compared to TWL6035.
The patch series is based on the patch:
http://www.mail-archive.com/[email protected]/msg90598.html
V3:
Implements Interrupts check using i2c->irq variable instead of DT
"interrupts" property.
Cleans ups in assiging the features variable in patch 2.
V2:
Implements Interrupts checking via DT instead of creating flags
and checking based on chip ID.
J Keerthy (4):
MFD: Palmas: Check if irq is valid
MFD: Palmas: Add SMPS10_BOOST feature
mfd: Palmas: Add TPS659038 PMIC support
regulator: Palmas: Add TPS659038 support
Documentation/devicetree/bindings/mfd/palmas.txt | 2 +
.../devicetree/bindings/regulator/palmas-pmic.txt | 1 +
drivers/mfd/palmas.c | 38 ++++++++++++++++----
drivers/regulator/palmas-regulator.c | 4 ++
include/linux/mfd/palmas.h | 14 +++++++
5 files changed, 52 insertions(+), 7 deletions(-)
--
1.7.5.4
From: J Keerthy <[email protected]>
Check if irq value obtained is valid. If it is not valid
then skip the irq request step and go ahead with the probe.
Signed-off-by: J Keerthy <[email protected]>
---
drivers/mfd/palmas.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index 62fa728..b24bee3 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -290,6 +290,11 @@ static int palmas_i2c_probe(struct i2c_client *i2c,
}
}
+ if (!palmas->irq) {
+ dev_warn(palmas->dev, "IRQ missing: skipping irq request\n");
+ goto no_irq;
+ }
+
/* Change interrupt line output polarity */
if (pdata->irq_flags & IRQ_TYPE_LEVEL_HIGH)
reg = PALMAS_POLARITY_CTRL_INT_POLARITY;
@@ -316,6 +321,7 @@ static int palmas_i2c_probe(struct i2c_client *i2c,
if (ret < 0)
goto err;
+no_irq:
slave = PALMAS_BASE_TO_SLAVE(PALMAS_PU_PD_OD_BASE);
addr = PALMAS_BASE_TO_REG(PALMAS_PU_PD_OD_BASE,
PALMAS_PRIMARY_SECONDARY_PAD1);
--
1.7.5.4
From: J Keerthy <[email protected]>
The SMPS10 regulator is not presesnt in all the variants
of the PALMAS PMIC family. Hence adding a feature to distingush
between them.
Signed-off-by: J Keerthy <[email protected]>
---
drivers/mfd/palmas.c | 27 ++++++++++++++++++++-------
drivers/regulator/palmas-regulator.c | 3 +++
include/linux/mfd/palmas.h | 14 ++++++++++++++
3 files changed, 37 insertions(+), 7 deletions(-)
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index b24bee3..1cacc6a 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -231,6 +231,16 @@ static void palmas_dt_to_pdata(struct i2c_client *i2c,
palmas_set_pdata_irq_flag(i2c, pdata);
}
+static unsigned int palmas_features = PALMAS_PMIC_FEATURE_SMPS10_BOOST;
+
+static const struct of_device_id of_palmas_match_tbl[] = {
+ {
+ .compatible = "ti,palmas",
+ .data = &palmas_features,
+ },
+ { },
+};
+
static int palmas_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
{
@@ -238,8 +248,9 @@ static int palmas_i2c_probe(struct i2c_client *i2c,
struct palmas_platform_data *pdata;
struct device_node *node = i2c->dev.of_node;
int ret = 0, i;
- unsigned int reg, addr;
+ unsigned int reg, addr, *features;
int slave;
+ const struct of_device_id *match;
pdata = dev_get_platdata(&i2c->dev);
@@ -261,9 +272,16 @@ static int palmas_i2c_probe(struct i2c_client *i2c,
i2c_set_clientdata(i2c, palmas);
palmas->dev = &i2c->dev;
- palmas->id = id->driver_data;
palmas->irq = i2c->irq;
+ match = of_match_device(of_match_ptr(of_palmas_match_tbl), &i2c->dev);
+
+ if (!match)
+ return -ENODATA;
+
+ features = (unsigned int *)match->data;
+ palmas->features = *features;
+
for (i = 0; i < PALMAS_NUM_CLIENTS; i++) {
if (i == 0)
palmas->i2c_clients[i] = i2c;
@@ -433,11 +451,6 @@ static const struct i2c_device_id palmas_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, palmas_i2c_id);
-static struct of_device_id of_palmas_match_tbl[] = {
- { .compatible = "ti,palmas", },
- { /* end */ }
-};
-
static struct i2c_driver palmas_i2c_driver = {
.driver = {
.name = "palmas",
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index 3ae44ac..1ae1e83 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -838,6 +838,9 @@ static int palmas_regulators_probe(struct platform_device *pdev)
continue;
ramp_delay_support = true;
break;
+ case PALMAS_REG_SMPS10:
+ if (!PALMAS_PMIC_HAS(palmas, SMPS10_BOOST))
+ continue;
}
if ((id == PALMAS_REG_SMPS6) || (id == PALMAS_REG_SMPS8))
diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
index 8f21daf..98058ca 100644
--- a/include/linux/mfd/palmas.h
+++ b/include/linux/mfd/palmas.h
@@ -32,6 +32,19 @@
((a) == PALMAS_CHIP_ID))
#define is_palmas_charger(a) ((a) == PALMAS_CHIP_CHARGER_ID)
+/**
+ * Palmas PMIC feature types
+ *
+ * PALMAS_PMIC_FEATURE_SMPS10_BOOST - used when the PMIC provides SMPS10_BOOST
+ * regulator.
+ *
+ * PALMAS_PMIC_HAS(b, f) - macro to check if a bandgap device is capable of a
+ * specific feature (above) or not. Return non-zero, if yes.
+ */
+#define PALMAS_PMIC_FEATURE_SMPS10_BOOST BIT(0)
+#define PALMAS_PMIC_HAS(b, f) \
+ ((b)->features & PALMAS_PMIC_FEATURE_ ## f)
+
struct palmas_pmic;
struct palmas_gpadc;
struct palmas_resource;
@@ -46,6 +59,7 @@ struct palmas {
/* Stored chip id */
int id;
+ unsigned int features;
/* IRQ Data */
int irq;
u32 irq_mask;
--
1.7.5.4
From: J Keerthy <[email protected]>
The Patch adds TPS659038 PMIC support in the palmas mfd driver.
The TPS659038 has almost the same registers as of the earlier
supported variants of PALMAS family such as the TWL6035.
The critical differences between TPS659038 and TWL6035 being:
1) TPS659038 has nothing related to battery charging and back up battery stuff.
2) TPS659038 does not have does not have SMPS10(Boost) step up convertor.
3) TPS659038 does not have Battery detection and anything related to battery.
4) SD card detection, Battery presence detection, Vibrator, USB OTG are missing
when compared to TWL6035.
Signed-off-by: J Keerthy <[email protected]>
---
Documentation/devicetree/bindings/mfd/palmas.txt | 2 ++
drivers/mfd/palmas.c | 5 +++++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt b/Documentation/devicetree/bindings/mfd/palmas.txt
index 7bcd59c..89cb773 100644
--- a/Documentation/devicetree/bindings/mfd/palmas.txt
+++ b/Documentation/devicetree/bindings/mfd/palmas.txt
@@ -5,6 +5,7 @@ twl6035 (palmas)
twl6037 (palmas)
tps65913 (palmas)
tps65914 (palmas)
+tps659038
Required properties:
- compatible : Should be from the list
@@ -14,6 +15,7 @@ Required properties:
ti,tps65913
ti,tps65914
ti,tps80036
+ ti,tps659038
and also the generic series names
ti,palmas
- interrupt-controller : palmas has its own internal IRQs
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index 1cacc6a..0439edb 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -232,12 +232,17 @@ static void palmas_dt_to_pdata(struct i2c_client *i2c,
}
static unsigned int palmas_features = PALMAS_PMIC_FEATURE_SMPS10_BOOST;
+static unsigned int tps659038_features;
static const struct of_device_id of_palmas_match_tbl[] = {
{
.compatible = "ti,palmas",
.data = &palmas_features,
},
+ {
+ .compatible = "ti,tps659038",
+ .data = &tps659038_features,
+ },
{ },
};
--
1.7.5.4
From: J Keerthy <[email protected]>
Add TPS659038 support.
Signed-off-by: J Keerthy <[email protected]>
---
.../devicetree/bindings/regulator/palmas-pmic.txt | 1 +
drivers/regulator/palmas-regulator.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
index d5a3086..5115cd7 100644
--- a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
+++ b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
@@ -7,6 +7,7 @@ Required properties:
ti,twl6037-pmic
ti,tps65913-pmic
ti,tps65914-pmic
+ ti,tps659038-pmic
and also the generic series names
ti,palmas-pmic
- interrupt-parent : The parent interrupt controller which is palmas.
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index 1ae1e83..d0c8785 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -1054,6 +1054,7 @@ static struct of_device_id of_palmas_match_tbl[] = {
{ .compatible = "ti,tps65913-pmic", },
{ .compatible = "ti,tps65914-pmic", },
{ .compatible = "ti,tps80036-pmic", },
+ { .compatible = "ti,tps659038-pmic", },
{ /* end */ }
};
--
1.7.5.4
On Wed, Jun 19, 2013 at 11:27:50AM +0530, Keerthy wrote:
> From: J Keerthy <[email protected]>
>
> Add TPS659038 support.
>
> Signed-off-by: J Keerthy <[email protected]>
This doesn't apply against my current tree as the PMIC bindings document
isn't in mainline yet.
Acked-by: Mark Brown <[email protected]>
assuming there's a tree where that does exist.
On Wed, Jun 19, 2013 at 11:27:47AM +0530, Keerthy wrote:
> From: J Keerthy <[email protected]>
>
> Check if irq value obtained is valid. If it is not valid
> then skip the irq request step and go ahead with the probe.
>
> Signed-off-by: J Keerthy <[email protected]>
Reviewed-by: Mark Brown <[email protected]>
On 06/18/2013 11:57 PM, Keerthy wrote:
> From: J Keerthy <[email protected]>
>
> Check if irq value obtained is valid. If it is not valid
> then skip the irq request step and go ahead with the probe.
Reviewed-by: Stephen Warren <[email protected]>
> -----Original Message-----
> From: Mark Brown [mailto:[email protected]]
> Sent: Wednesday, June 19, 2013 10:13 PM
> To: J, KEERTHY
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; devicetree-
> [email protected]; [email protected]
> Subject: Re: [PATCH v3 1/4] MFD: Palmas: Check if irq is valid
>
> On Wed, Jun 19, 2013 at 11:27:47AM +0530, Keerthy wrote:
> > From: J Keerthy <[email protected]>
> >
> > Check if irq value obtained is valid. If it is not valid then skip
> the
> > irq request step and go ahead with the probe.
> >
> > Signed-off-by: J Keerthy <[email protected]>
>
> Reviewed-by: Mark Brown <[email protected]>
Thanks Mark.
> -----Original Message-----
> From: Mark Brown [mailto:[email protected]]
> Sent: Wednesday, June 19, 2013 10:12 PM
> To: J, KEERTHY
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; devicetree-
> [email protected]; [email protected]
> Subject: Re: [PATCH v3 4/4] regulator: Palmas: Add TPS659038 support
>
> On Wed, Jun 19, 2013 at 11:27:50AM +0530, Keerthy wrote:
> > From: J Keerthy <[email protected]>
> >
> > Add TPS659038 support.
> >
> > Signed-off-by: J Keerthy <[email protected]>
>
> This doesn't apply against my current tree as the PMIC bindings
> document isn't in mainline yet.
It was pulled by Grant.
>
> Acked-by: Mark Brown <[email protected]>
>
> assuming there's a tree where that does exist.
Thanks. I will check if Grant can pull this.
> -----Original Message-----
> From: Stephen Warren [mailto:[email protected]]
> Sent: Wednesday, June 19, 2013 10:39 PM
> To: J, KEERTHY
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH v3 1/4] MFD: Palmas: Check if irq is valid
>
> On 06/18/2013 11:57 PM, Keerthy wrote:
> > From: J Keerthy <[email protected]>
> >
> > Check if irq value obtained is valid. If it is not valid then skip
> the
> > irq request step and go ahead with the probe.
>
> Reviewed-by: Stephen Warren <[email protected]>
Thanks Stephen.
Hi Samuel,
> -----Original Message-----
> From: Stephen Warren [mailto:[email protected]]
> Sent: Wednesday, June 19, 2013 10:39 PM
> To: J, KEERTHY
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH v3 1/4] MFD: Palmas: Check if irq is valid
>
> On 06/18/2013 11:57 PM, Keerthy wrote:
> > From: J Keerthy <[email protected]>
> >
> > Check if irq value obtained is valid. If it is not valid then skip
> the
> > irq request step and go ahead with the probe.
>
> Reviewed-by: Stephen Warren <[email protected]>
Could you please pull this?
Kind Regards,
Keerthy
Hello Samuel,
> -----Original Message-----
> From: J, KEERTHY
> Sent: Wednesday, June 19, 2013 11:28 AM
> To: [email protected]
> Cc: [email protected]; J, KEERTHY; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; devicetree-
> [email protected]; [email protected]
> Subject: [PATCH v3 2/4] MFD: Palmas: Add SMPS10_BOOST feature
>
> From: J Keerthy <[email protected]>
>
> The SMPS10 regulator is not presesnt in all the variants of the PALMAS
> PMIC family. Hence adding a feature to distingush between them.
>
Could you please pull this patch?
> Signed-off-by: J Keerthy <[email protected]>
> ---
> drivers/mfd/palmas.c | 27 ++++++++++++++++++++------
> -
> drivers/regulator/palmas-regulator.c | 3 +++
> include/linux/mfd/palmas.h | 14 ++++++++++++++
> 3 files changed, 37 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c index
> b24bee3..1cacc6a 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -231,6 +231,16 @@ static void palmas_dt_to_pdata(struct i2c_client
> *i2c,
> palmas_set_pdata_irq_flag(i2c, pdata); }
>
> +static unsigned int palmas_features =
> PALMAS_PMIC_FEATURE_SMPS10_BOOST;
> +
> +static const struct of_device_id of_palmas_match_tbl[] = {
> + {
> + .compatible = "ti,palmas",
> + .data = &palmas_features,
> + },
> + { },
> +};
> +
> static int palmas_i2c_probe(struct i2c_client *i2c,
> const struct i2c_device_id *id)
> {
> @@ -238,8 +248,9 @@ static int palmas_i2c_probe(struct i2c_client *i2c,
> struct palmas_platform_data *pdata;
> struct device_node *node = i2c->dev.of_node;
> int ret = 0, i;
> - unsigned int reg, addr;
> + unsigned int reg, addr, *features;
> int slave;
> + const struct of_device_id *match;
>
> pdata = dev_get_platdata(&i2c->dev);
>
> @@ -261,9 +272,16 @@ static int palmas_i2c_probe(struct i2c_client
> *i2c,
>
> i2c_set_clientdata(i2c, palmas);
> palmas->dev = &i2c->dev;
> - palmas->id = id->driver_data;
> palmas->irq = i2c->irq;
>
> + match = of_match_device(of_match_ptr(of_palmas_match_tbl), &i2c-
> >dev);
> +
> + if (!match)
> + return -ENODATA;
> +
> + features = (unsigned int *)match->data;
> + palmas->features = *features;
> +
> for (i = 0; i < PALMAS_NUM_CLIENTS; i++) {
> if (i == 0)
> palmas->i2c_clients[i] = i2c;
> @@ -433,11 +451,6 @@ static const struct i2c_device_id palmas_i2c_id[]
> = { }; MODULE_DEVICE_TABLE(i2c, palmas_i2c_id);
>
> -static struct of_device_id of_palmas_match_tbl[] = {
> - { .compatible = "ti,palmas", },
> - { /* end */ }
> -};
> -
> static struct i2c_driver palmas_i2c_driver = {
> .driver = {
> .name = "palmas",
> diff --git a/drivers/regulator/palmas-regulator.c
> b/drivers/regulator/palmas-regulator.c
> index 3ae44ac..1ae1e83 100644
> --- a/drivers/regulator/palmas-regulator.c
> +++ b/drivers/regulator/palmas-regulator.c
> @@ -838,6 +838,9 @@ static int palmas_regulators_probe(struct
> platform_device *pdev)
> continue;
> ramp_delay_support = true;
> break;
> + case PALMAS_REG_SMPS10:
> + if (!PALMAS_PMIC_HAS(palmas, SMPS10_BOOST))
> + continue;
> }
>
> if ((id == PALMAS_REG_SMPS6) || (id == PALMAS_REG_SMPS8))
> diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
> index 8f21daf..98058ca 100644
> --- a/include/linux/mfd/palmas.h
> +++ b/include/linux/mfd/palmas.h
> @@ -32,6 +32,19 @@
> ((a) == PALMAS_CHIP_ID))
> #define is_palmas_charger(a) ((a) == PALMAS_CHIP_CHARGER_ID)
>
> +/**
> + * Palmas PMIC feature types
> + *
> + * PALMAS_PMIC_FEATURE_SMPS10_BOOST - used when the PMIC provides
> SMPS10_BOOST
> + * regulator.
> + *
> + * PALMAS_PMIC_HAS(b, f) - macro to check if a bandgap device is
> capable of a
> + * specific feature (above) or not. Return non-zero, if yes.
> + */
> +#define PALMAS_PMIC_FEATURE_SMPS10_BOOST BIT(0)
> +#define PALMAS_PMIC_HAS(b, f) \
> + ((b)->features & PALMAS_PMIC_FEATURE_ ## f)
> +
> struct palmas_pmic;
> struct palmas_gpadc;
> struct palmas_resource;
> @@ -46,6 +59,7 @@ struct palmas {
> /* Stored chip id */
> int id;
>
> + unsigned int features;
> /* IRQ Data */
> int irq;
> u32 irq_mask;
> --
> 1.7.5.4
Regards,
Keerthy
Hi,
On Wed, Jun 19, 2013 at 11:27:46AM +0530, Keerthy wrote:
> From: J Keerthy <[email protected]>
>
> The Patch series adds TPS659038 PMIC support in the palmas MFD and Regulator
> drivers. The TPS659038 has almost the same registers as of the earlier
> supported variants of PALMAS family such as the TWL6035.
>
> The critical differences between TPS659038 and TWL6035 being:
>
> 1) TPS659038 has nothing related to battery charging and back up battery stuff.
> 2) TPS659038 does not have does not have SMPS10(Boost) step up convertor.
> 3) TPS659038 does not have Battery detection and anything related to battery.
> 4) SD card detection, Battery presence detection, Vibrator, USB OTG are missing
> when compared to TWL6035.
>
> The patch series is based on the patch:
> http://www.mail-archive.com/[email protected]/msg90598.html
>
> V3:
>
> Implements Interrupts check using i2c->irq variable instead of DT
> "interrupts" property.
>
> Cleans ups in assiging the features variable in patch 2.
>
> V2:
>
> Implements Interrupts checking via DT instead of creating flags
> and checking based on chip ID.
>
> J Keerthy (4):
> MFD: Palmas: Check if irq is valid
> MFD: Palmas: Add SMPS10_BOOST feature
> mfd: Palmas: Add TPS659038 PMIC support
> regulator: Palmas: Add TPS659038 support
I took the first 2 patches, but patch #3 does not apply.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
Hi,
On Wed, Jun 19, 2013 at 11:27:49AM +0530, Keerthy wrote:
> From: J Keerthy <[email protected]>
>
> The Patch adds TPS659038 PMIC support in the palmas mfd driver.
> The TPS659038 has almost the same registers as of the earlier
> supported variants of PALMAS family such as the TWL6035.
>
> The critical differences between TPS659038 and TWL6035 being:
>
> 1) TPS659038 has nothing related to battery charging and back up battery stuff.
> 2) TPS659038 does not have does not have SMPS10(Boost) step up convertor.
> 3) TPS659038 does not have Battery detection and anything related to battery.
> 4) SD card detection, Battery presence detection, Vibrator, USB OTG are missing
> when compared to TWL6035.
>
> Signed-off-by: J Keerthy <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/palmas.txt | 2 ++
> drivers/mfd/palmas.c | 5 +++++
> 2 files changed, 7 insertions(+), 0 deletions(-)
This one does not apply against mfd-next as I don't have the palmas.txt.
For Grant to take this one:
Acked-by: Samuel Ortiz <[email protected]>
If that creates conflicts (I already have a few palmas.c changes) then
we'll have to find a way to fix them (Me taking the bindings file ?).
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
Hi Samuel,
> -----Original Message-----
> From: Samuel Ortiz [mailto:[email protected]]
> Sent: Thursday, June 20, 2013 2:09 PM
> To: J, KEERTHY
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; devicetree-
> [email protected]; [email protected]
> Subject: Re: [PATCH v3 0/4] MFD: Palmas: Add TPS659038 PMIC support on
> Palmas
>
> Hi,
>
> On Wed, Jun 19, 2013 at 11:27:46AM +0530, Keerthy wrote:
> > From: J Keerthy <[email protected]>
> >
> > The Patch series adds TPS659038 PMIC support in the palmas MFD and
> > Regulator drivers. The TPS659038 has almost the same registers as of
> > the earlier supported variants of PALMAS family such as the TWL6035.
> >
> > The critical differences between TPS659038 and TWL6035 being:
> >
> > 1) TPS659038 has nothing related to battery charging and back up
> battery stuff.
> > 2) TPS659038 does not have does not have SMPS10(Boost) step up
> convertor.
> > 3) TPS659038 does not have Battery detection and anything related to
> battery.
> > 4) SD card detection, Battery presence detection, Vibrator, USB OTG
> are missing
> > when compared to TWL6035.
> >
> > The patch series is based on the patch:
> >
> > http://www.mail-archive.com/[email protected]/msg90598.html
> >
> > V3:
> >
> > Implements Interrupts check using i2c->irq variable instead of DT
> > "interrupts" property.
> >
> > Cleans ups in assiging the features variable in patch 2.
> >
> > V2:
> >
> > Implements Interrupts checking via DT instead of creating flags and
> > checking based on chip ID.
> >
> > J Keerthy (4):
> > MFD: Palmas: Check if irq is valid
> > MFD: Palmas: Add SMPS10_BOOST feature
> > mfd: Palmas: Add TPS659038 PMIC support
> > regulator: Palmas: Add TPS659038 support
> I took the first 2 patches, but patch #3 does not apply.
>
Thanks. I will split 3 and 4 separating Documentation files.
The Documentation was taken by Grant. So I will split the
Patches 3 and 4 and send a separate series. Thanks again for pulling
1 and 2.
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
Regards,
Keerthy
Hi,
On Thu, Jun 20, 2013 at 04:34:42AM +0000, J, KEERTHY wrote:
> > -----Original Message-----
> > From: J, KEERTHY
> > Sent: Wednesday, June 19, 2013 11:28 AM
> > To: [email protected]
> > Cc: [email protected]; J, KEERTHY; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; devicetree-
> > [email protected]; [email protected]
> > Subject: [PATCH v3 2/4] MFD: Palmas: Add SMPS10_BOOST feature
> >
> > From: J Keerthy <[email protected]>
> >
> > The SMPS10 regulator is not presesnt in all the variants of the PALMAS
> > PMIC family. Hence adding a feature to distingush between them.
> >
>
> Could you please pull this patch?
I'm reverting this one for now as of_match_device is not define for
!CONFIG_OF.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
Hi Samuel,
> -----Original Message-----
> From: Samuel Ortiz [mailto:[email protected]]
> Sent: Thursday, June 20, 2013 2:38 PM
> To: J, KEERTHY
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; devicetree-
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: Re: [PATCH v3 2/4] MFD: Palmas: Add SMPS10_BOOST feature
>
> Hi,
>
> On Thu, Jun 20, 2013 at 04:34:42AM +0000, J, KEERTHY wrote:
> > > -----Original Message-----
> > > From: J, KEERTHY
> > > Sent: Wednesday, June 19, 2013 11:28 AM
> > > To: [email protected]
> > > Cc: [email protected]; J, KEERTHY; [email protected];
> > > [email protected]; [email protected];
> > > [email protected]; [email protected];
> > > [email protected]; devicetree- [email protected];
> > > [email protected]
> > > Subject: [PATCH v3 2/4] MFD: Palmas: Add SMPS10_BOOST feature
> > >
> > > From: J Keerthy <[email protected]>
> > >
> > > The SMPS10 regulator is not presesnt in all the variants of the
> > > PALMAS PMIC family. Hence adding a feature to distingush between
> them.
> > >
> >
> > Could you please pull this patch?
> I'm reverting this one for now as of_match_device is not define for
> !CONFIG_OF.
So the of_match_device parts can come under #ifdef CONFIG_OF?
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
Regards,
Keerthy
On Thu, Jun 20, 2013 at 09:13:06AM +0000, J, KEERTHY wrote:
> > > Could you please pull this patch?
> > I'm reverting this one for now as of_match_device is not define for
> > !CONFIG_OF.
>
> So the of_match_device parts can come under #ifdef CONFIG_OF?
Nevermind, you were "just" missing an of_device.h inclusion. I fixed
that up and applied your patch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
> -----Original Message-----
> From: Samuel Ortiz [mailto:[email protected]]
> Sent: Thursday, June 20, 2013 2:57 PM
> To: J, KEERTHY
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; devicetree-
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: Re: [PATCH v3 2/4] MFD: Palmas: Add SMPS10_BOOST feature
>
> On Thu, Jun 20, 2013 at 09:13:06AM +0000, J, KEERTHY wrote:
> > > > Could you please pull this patch?
> > > I'm reverting this one for now as of_match_device is not define for
> > > !CONFIG_OF.
> >
> > So the of_match_device parts can come under #ifdef CONFIG_OF?
> Nevermind, you were "just" missing an of_device.h inclusion. I fixed
> that up and applied your patch.
Oops..I get it. Thanks.
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
On Wed, 19 Jun 2013, Keerthy wrote:
> From: J Keerthy <[email protected]>
>
> Check if irq value obtained is valid. If it is not valid
> then skip the irq request step and go ahead with the probe.
>
> Signed-off-by: J Keerthy <[email protected]>
> ---
> drivers/mfd/palmas.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
Applied with Stephen and Mark's RB.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
On Thu, 11 Jul 2013, Lee Jones wrote:
> On Wed, 19 Jun 2013, Keerthy wrote:
>
> > From: J Keerthy <[email protected]>
> >
> > Check if irq value obtained is valid. If it is not valid
> > then skip the irq request step and go ahead with the probe.
> >
> > Signed-off-by: J Keerthy <[email protected]>
> > ---
> > drivers/mfd/palmas.c | 6 ++++++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
>
> Applied with Stephen and Mark's RB.
Scrap that, it appears to be applied already.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog