LinuxLists.cc - linux-next: build failure after merge of the final tree (staging tree related)

2013-06-19 08:10:41

Subject: linux-next: build failure after merge of the final tree (staging tree related)

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:203:0,
from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:67,
from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:41:
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_dev_need_failover':
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:215:16: error: implicit declaration of function 'NIPQUAD' [-Werror=implicit-function-declaration]
static struct libcfs_debug_msg_data msgdata; \
^
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:231:2: note: in expansion of macro '__CDEBUG'
__CDEBUG(&cdls, mask, format, ## __VA_ARGS__);\
^
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:238:30: note: in expansion of macro 'CDEBUG_LIMIT'
#define CERROR(format, ...) CDEBUG_LIMIT(D_ERROR, format, ## __VA_ARGS__)
^
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2577:3: note: in expansion of macro 'CERROR'
CERROR("Failed to bind %s:%u.%u.%u.%u to device(%p): %d\n",
^

I have once again disabled the building og the lustre client code.

--
Cheers,
Stephen Rothwell [email protected]

Attachments:

(No filename) (1.31 kB)
(No filename) (836.00 B)
Download all attachments

2013-06-19 09:27:22

by Peng Tao

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)

On Wed, Jun 19, 2013 at 4:10 PM, Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:203:0,
> from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:67,
> from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:41:
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_dev_need_failover':
> drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:215:16: error: implicit declaration of function 'NIPQUAD' [-Werror=implicit-function-declaration]
> static struct libcfs_debug_msg_data msgdata; \
> ^
Thanks for reporting!

It is a bug in Lustre code that it is missing NIPQUAD definition on
Linux platform. I will send fix later.

> drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:231:2: note: in expansion of macro '__CDEBUG'
> __CDEBUG(&cdls, mask, format, ## __VA_ARGS__);\
> ^
> drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:238:30: note: in expansion of macro 'CDEBUG_LIMIT'
> #define CERROR(format, ...) CDEBUG_LIMIT(D_ERROR, format, ## __VA_ARGS__)
> ^
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2577:3: note: in expansion of macro 'CERROR'
> CERROR("Failed to bind %s:%u.%u.%u.%u to device(%p): %d\n",
> ^
>
> I have once again disabled the building og the lustre client code.
>
Sorry that Lustre is mostly tested only on x86 platform (and sadly I
don't have other architectures to test on.). We sincerely thank you
for your continuous help.

Cheers,
Tao

2013-06-19 14:37:17

by Greg KH

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)

On Wed, Jun 19, 2013 at 05:26:57PM +0800, Peng Tao wrote:
> On Wed, Jun 19, 2013 at 4:10 PM, Stephen Rothwell <[email protected]> wrote:
> > Hi all,
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:203:0,
> > from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:67,
> > from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:41:
> > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_dev_need_failover':
> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:215:16: error: implicit declaration of function 'NIPQUAD' [-Werror=implicit-function-declaration]
> > static struct libcfs_debug_msg_data msgdata; \
> > ^
> Thanks for reporting!
>
> It is a bug in Lustre code that it is missing NIPQUAD definition on
> Linux platform. I will send fix later.
>
> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:231:2: note: in expansion of macro '__CDEBUG'
> > __CDEBUG(&cdls, mask, format, ## __VA_ARGS__);\
> > ^
> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:238:30: note: in expansion of macro 'CDEBUG_LIMIT'
> > #define CERROR(format, ...) CDEBUG_LIMIT(D_ERROR, format, ## __VA_ARGS__)
> > ^
> > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2577:3: note: in expansion of macro 'CERROR'
> > CERROR("Failed to bind %s:%u.%u.%u.%u to device(%p): %d\n",
> > ^
> >
> > I have once again disabled the building og the lustre client code.
> >
> Sorry that Lustre is mostly tested only on x86 platform (and sadly I
> don't have other architectures to test on.). We sincerely thank you
> for your continuous help.

You can always use a ppc cross compiler for just the kernel build tests
to catch things like this.

thanks,

greg k-h

2013-06-20 10:52:44

by Peng Tao

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)

On Wed, Jun 19, 2013 at 10:37 PM, Greg KH <[email protected]> wrote:
> On Wed, Jun 19, 2013 at 05:26:57PM +0800, Peng Tao wrote:
>> On Wed, Jun 19, 2013 at 4:10 PM, Stephen Rothwell <[email protected]> wrote:
>> > Hi all,
>> >
>> > After merging the final tree, today's linux-next build (powerpc
>> > allyesconfig) failed like this:
>> >
>> > In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:203:0,
>> > from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:67,
>> > from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:41:
>> > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_dev_need_failover':
>> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:215:16: error: implicit declaration of function 'NIPQUAD' [-Werror=implicit-function-declaration]
>> > static struct libcfs_debug_msg_data msgdata; \
>> > ^
>> Thanks for reporting!
>>
>> It is a bug in Lustre code that it is missing NIPQUAD definition on
>> Linux platform. I will send fix later.
>>
>> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:231:2: note: in expansion of macro '__CDEBUG'
>> > __CDEBUG(&cdls, mask, format, ## __VA_ARGS__);\
>> > ^
>> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:238:30: note: in expansion of macro 'CDEBUG_LIMIT'
>> > #define CERROR(format, ...) CDEBUG_LIMIT(D_ERROR, format, ## __VA_ARGS__)
>> > ^
>> > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2577:3: note: in expansion of macro 'CERROR'
>> > CERROR("Failed to bind %s:%u.%u.%u.%u to device(%p): %d\n",
>> > ^
>> >
>> > I have once again disabled the building og the lustre client code.
>> >
>> Sorry that Lustre is mostly tested only on x86 platform (and sadly I
>> don't have other architectures to test on.). We sincerely thank you
>> for your continuous help.
>
> You can always use a ppc cross compiler for just the kernel build tests
> to catch things like this.
>
Thanks for the suggestion. I've set up cross compiler for powerpc and
found a few more bugs. Will send patches to fix them later.

Cheers,
Tao

2013-06-24 22:40:39

by Greg KH

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)

2013-06-24 23:41:02

by Stephen Rothwell

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)

Hi Greg,

On Mon, 24 Jun 2013 15:40:35 -0700 Greg KH <[email protected]> wrote:
>
> We are running out of time, my tree is pretty much closed for 3.11 now,
> should I just disable the build of this module for 3.11?

That's what I've been doing - it has never been enabled in a final
linux-next release. So, it should probably just be disabled properly.

--
Cheers,
Stephen Rothwell [email protected]

Attachments:

(No filename) (421.00 B)
(No filename) (836.00 B)
Download all attachments

2013-06-24 23:50:08

by Greg KH

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)

On Tue, Jun 25, 2013 at 09:40:51AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Mon, 24 Jun 2013 15:40:35 -0700 Greg KH <[email protected]> wrote:
> >
> > We are running out of time, my tree is pretty much closed for 3.11 now,
> > should I just disable the build of this module for 3.11?
>
> That's what I've been doing - it has never been enabled in a final
> linux-next release. So, it should probably just be disabled properly.

I agree, now disabled.

greg k-h

2013-06-25 00:22:58

by Peng Tao

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)

On 06/25/2013 07:50 AM, Greg KH wrote:
> On Tue, Jun 25, 2013 at 09:40:51AM +1000, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> On Mon, 24 Jun 2013 15:40:35 -0700 Greg KH <[email protected]> wrote:
>>> We are running out of time, my tree is pretty much closed for 3.11 now,
>>> should I just disable the build of this module for 3.11?
>> That's what I've been doing - it has never been enabled in a final
>> linux-next release. So, it should probably just be disabled properly.
> I agree, now disabled.
>
> greg k-h
Greg,

Sorry for the delay. I've been caught up by other build failures that
were found during my tests. I'm sending you the latest patches that
should fix all the build errors. I've verified that we can now pass
build on sparc/mips/s390/powerpc/x86, both 32bits and 64bits. Please
help to queue them.

I see that you have already disabled Lustre build. Can we re-enable it
or do we have to wait until 3.10 is released?

Thanks,
Tao

2013-06-25 02:13:07

by Greg KH

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)

On Tue, Jun 25, 2013 at 08:22:49AM +0800, Peng Tao wrote:
> On 06/25/2013 07:50 AM, Greg KH wrote:
> >On Tue, Jun 25, 2013 at 09:40:51AM +1000, Stephen Rothwell wrote:
> >>Hi Greg,
> >>
> >>On Mon, 24 Jun 2013 15:40:35 -0700 Greg KH <[email protected]> wrote:
> >>>We are running out of time, my tree is pretty much closed for 3.11 now,
> >>>should I just disable the build of this module for 3.11?
> >>That's what I've been doing - it has never been enabled in a final
> >>linux-next release. So, it should probably just be disabled properly.
> >I agree, now disabled.
> >
> >greg k-h
> Greg,
>
> Sorry for the delay. I've been caught up by other build failures
> that were found during my tests. I'm sending you the latest patches
> that should fix all the build errors. I've verified that we can now
> pass build on sparc/mips/s390/powerpc/x86, both 32bits and 64bits.
> Please help to queue them.
>
> I see that you have already disabled Lustre build. Can we re-enable
> it or do we have to wait until 3.10 is released?

My trees mare now closed for 3.11, given that 3.10 will be released in
less than a week. I'll keep patches in my to-apply mailbox, which I
will then apply after 3.11-rc1 is out, so I'll not be accepting anything
for the next 3 weeks or so.

thanks,

greg k-h