2013-06-21 08:29:18

by George Cherian

[permalink] [raw]
Subject: [PATCH] usb: host: xhci-plat: release mem region while removing module

Do a release_mem_region of the hcd resource. Without this the
subsequent insertion of module fails in request_mem_region.

Signed-off-by: George Cherian <[email protected]>
---
drivers/usb/host/xhci-plat.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index df90fe5..93ad67e 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -179,6 +179,7 @@ static int xhci_plat_remove(struct platform_device *dev)

usb_remove_hcd(hcd);
iounmap(hcd->regs);
+ release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
usb_put_hcd(hcd);
kfree(xhci);

--
1.8.1.4


2013-06-24 14:22:33

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH] usb: host: xhci-plat: release mem region while removing module

On Fri, Jun 21, 2013 at 01:59:08PM +0530, George Cherian wrote:
> Do a release_mem_region of the hcd resource. Without this the
> subsequent insertion of module fails in request_mem_region.
>
> Signed-off-by: George Cherian <[email protected]>

very nice catch.

Acked-by: Felipe Balbi <[email protected]>

You need to resend with:

Cc: <[email protected]> # v3.4+

Not sure if Sarah wants to take care of the stable tagging, though.

--
balbi


Attachments:
(No filename) (451.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments

2013-06-25 18:23:59

by Sarah Sharp

[permalink] [raw]
Subject: Re: [PATCH] usb: host: xhci-plat: release mem region while removing module

On Mon, Jun 24, 2013 at 05:22:24PM +0300, Felipe Balbi wrote:
> On Fri, Jun 21, 2013 at 01:59:08PM +0530, George Cherian wrote:
> > Do a release_mem_region of the hcd resource. Without this the
> > subsequent insertion of module fails in request_mem_region.
> >
> > Signed-off-by: George Cherian <[email protected]>
>
> very nice catch.
>
> Acked-by: Felipe Balbi <[email protected]>
>
> You need to resend with:
>
> Cc: <[email protected]> # v3.4+
>
> Not sure if Sarah wants to take care of the stable tagging, though.

I'll take care of the stable tagging.

Sarah Sharp