2013-06-26 10:00:33

by Sachin Kamat

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] uio: Use of_match_ptr() macro in uio_pdrv_genirq.c

On 26 June 2013 15:22, Michal Simek <[email protected]> wrote:
> This eliminates having an #ifdef returning NULL for the case
> when OF is disabled.
>
> Signed-off-by: Michal Simek <[email protected]>

I have already submitted a similar patch for doing this:
https://lkml.org/lkml/2013/3/14/169

--
With regards,
Sachin

2013-06-26 10:21:32

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] uio: Use of_match_ptr() macro in uio_pdrv_genirq.c

On 06/26/2013 12:00 PM, Sachin Kamat wrote:
> On 26 June 2013 15:22, Michal Simek <[email protected]> wrote:
>> This eliminates having an #ifdef returning NULL for the case
>> when OF is disabled.
>>
>> Signed-off-by: Michal Simek <[email protected]>
>
> I have already submitted a similar patch for doing this:
> https://lkml.org/lkml/2013/3/14/169

Ok. I don't care about it.
Greg: Can you please add any of this patch to your char-misc tree?

For Sachin patch.
Acked-by: Michal Simek <[email protected]>

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature

2013-06-26 10:51:47

by Sachin Kamat

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] uio: Use of_match_ptr() macro in uio_pdrv_genirq.c

On 26 June 2013 15:51, Michal Simek <[email protected]> wrote:
> On 06/26/2013 12:00 PM, Sachin Kamat wrote:
>> On 26 June 2013 15:22, Michal Simek <[email protected]> wrote:
>>> This eliminates having an #ifdef returning NULL for the case
>>> when OF is disabled.
>>>
>>> Signed-off-by: Michal Simek <[email protected]>
>>
>> I have already submitted a similar patch for doing this:
>> https://lkml.org/lkml/2013/3/14/169
>
> Ok. I don't care about it.
> Greg: Can you please add any of this patch to your char-misc tree?
>
> For Sachin patch.
> Acked-by: Michal Simek <[email protected]>

Thanks Michal. Since Hans wasn't active the patch has been pending
since some time.
The latest rebased version has been posted [1] for Greg to apply.

[1] https://lkml.org/lkml/2013/6/25/7

--
With warm regards,
Sachin

2013-06-26 11:04:38

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] uio: Use of_match_ptr() macro in uio_pdrv_genirq.c

On 06/26/2013 12:51 PM, Sachin Kamat wrote:
> On 26 June 2013 15:51, Michal Simek <[email protected]> wrote:
>> On 06/26/2013 12:00 PM, Sachin Kamat wrote:
>>> On 26 June 2013 15:22, Michal Simek <[email protected]> wrote:
>>>> This eliminates having an #ifdef returning NULL for the case
>>>> when OF is disabled.
>>>>
>>>> Signed-off-by: Michal Simek <[email protected]>
>>>
>>> I have already submitted a similar patch for doing this:
>>> https://lkml.org/lkml/2013/3/14/169
>>
>> Ok. I don't care about it.
>> Greg: Can you please add any of this patch to your char-misc tree?
>>
>> For Sachin patch.
>> Acked-by: Michal Simek <[email protected]>
>
> Thanks Michal. Since Hans wasn't active the patch has been pending
> since some time.
> The latest rebased version has been posted [1] for Greg to apply.
>
> [1] https://lkml.org/lkml/2013/6/25/7


Yeah. As I said I really don't care which version will be applied.
It is just necessary to have progress on this.

Here is the first version I have sent
http://lkml.org/lkml/2013/5/23/311

btw: do you agree about removing that uio_pdrv because
all functionality is already in uio_pdrv_genirq driver
and make no sense to have two drivers for the same thing?

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature

2013-06-26 11:13:45

by Sachin Kamat

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] uio: Use of_match_ptr() macro in uio_pdrv_genirq.c

On 26 June 2013 16:34, Michal Simek <[email protected]> wrote:
> On 06/26/2013 12:51 PM, Sachin Kamat wrote:
>> On 26 June 2013 15:51, Michal Simek <[email protected]> wrote:
>>> On 06/26/2013 12:00 PM, Sachin Kamat wrote:
>>>> On 26 June 2013 15:22, Michal Simek <[email protected]> wrote:
>>>>> This eliminates having an #ifdef returning NULL for the case
>>>>> when OF is disabled.
>>>>>
>>>>> Signed-off-by: Michal Simek <[email protected]>
>>>>
>>>> I have already submitted a similar patch for doing this:
>>>> https://lkml.org/lkml/2013/3/14/169
>>>
>>> Ok. I don't care about it.
>>> Greg: Can you please add any of this patch to your char-misc tree?
>>>
>>> For Sachin patch.
>>> Acked-by: Michal Simek <[email protected]>
>>
>> Thanks Michal. Since Hans wasn't active the patch has been pending
>> since some time.
>> The latest rebased version has been posted [1] for Greg to apply.
>>
>> [1] https://lkml.org/lkml/2013/6/25/7
>
>
> Yeah. As I said I really don't care which version will be applied.
> It is just necessary to have progress on this.
>
> Here is the first version I have sent
> http://lkml.org/lkml/2013/5/23/311
>
> btw: do you agree about removing that uio_pdrv because
> all functionality is already in uio_pdrv_genirq driver
> and make no sense to have two drivers for the same thing?

Sorry, I have'nt seen much of this code other than the obvious
cleanup for which I had sent the patch.

--
With warm regards,
Sachin

2013-06-26 11:48:02

by Vitalii Demianets

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] uio: Remove uio_pdrv and use uio_pdrv_genirq instead

On Wednesday 26 June 2013 12:52:12 Michal Simek wrote:
> The patch "UIO: fix uio_pdrv_genirq with device tree but no interrupt"
> (sha1: e3a3c3a205554e564751cd9c0276b2af813d7a92)
> add support to use this driver with no interrupts.
> uio_pdrv_genirq also supports device-tree binding
> which is not available in uio_pdrv.
>
> That's why this uio_pdrv driver can be just removed.
>

The idea is sound and I like it - it removes a lot of duplicated code.

Reviewed-by: Vitalii Demianets <[email protected]>

2013-06-26 12:50:25

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] uio: Use of_match_ptr() macro in uio_pdrv_genirq.c

On 06/26/2013 01:13 PM, Sachin Kamat wrote:
> On 26 June 2013 16:34, Michal Simek <[email protected]> wrote:
>> On 06/26/2013 12:51 PM, Sachin Kamat wrote:
>>> On 26 June 2013 15:51, Michal Simek <[email protected]> wrote:
>>>> On 06/26/2013 12:00 PM, Sachin Kamat wrote:
>>>>> On 26 June 2013 15:22, Michal Simek <[email protected]> wrote:
>>>>>> This eliminates having an #ifdef returning NULL for the case
>>>>>> when OF is disabled.
>>>>>>
>>>>>> Signed-off-by: Michal Simek <[email protected]>
>>>>>
>>>>> I have already submitted a similar patch for doing this:
>>>>> https://lkml.org/lkml/2013/3/14/169
>>>>
>>>> Ok. I don't care about it.
>>>> Greg: Can you please add any of this patch to your char-misc tree?
>>>>
>>>> For Sachin patch.
>>>> Acked-by: Michal Simek <[email protected]>
>>>
>>> Thanks Michal. Since Hans wasn't active the patch has been pending
>>> since some time.
>>> The latest rebased version has been posted [1] for Greg to apply.
>>>
>>> [1] https://lkml.org/lkml/2013/6/25/7
>>
>>
>> Yeah. As I said I really don't care which version will be applied.
>> It is just necessary to have progress on this.
>>
>> Here is the first version I have sent
>> http://lkml.org/lkml/2013/5/23/311
>>
>> btw: do you agree about removing that uio_pdrv because
>> all functionality is already in uio_pdrv_genirq driver
>> and make no sense to have two drivers for the same thing?
>
> Sorry, I have'nt seen much of this code other than the obvious
> cleanup for which I had sent the patch.

ok. Fair enough.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature

2013-06-26 14:59:23

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] uio: Use of_match_ptr() macro in uio_pdrv_genirq.c

On Wed, Jun 26, 2013 at 12:21:27PM +0200, Michal Simek wrote:
> On 06/26/2013 12:00 PM, Sachin Kamat wrote:
> > On 26 June 2013 15:22, Michal Simek <[email protected]> wrote:
> >> This eliminates having an #ifdef returning NULL for the case
> >> when OF is disabled.
> >>
> >> Signed-off-by: Michal Simek <[email protected]>
> >
> > I have already submitted a similar patch for doing this:
> > https://lkml.org/lkml/2013/3/14/169
>
> Ok. I don't care about it.
> Greg: Can you please add any of this patch to your char-misc tree?

I did that yesterday, can't you see it in there already, or did I mess
something up?

thanks,

greg k-h

2013-06-26 15:06:40

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] uio: Use of_match_ptr() macro in uio_pdrv_genirq.c

On 06/26/2013 05:00 PM, Greg Kroah-Hartman wrote:
> On Wed, Jun 26, 2013 at 12:21:27PM +0200, Michal Simek wrote:
>> On 06/26/2013 12:00 PM, Sachin Kamat wrote:
>>> On 26 June 2013 15:22, Michal Simek <[email protected]> wrote:
>>>> This eliminates having an #ifdef returning NULL for the case
>>>> when OF is disabled.
>>>>
>>>> Signed-off-by: Michal Simek <[email protected]>
>>>
>>> I have already submitted a similar patch for doing this:
>>> https://lkml.org/lkml/2013/3/14/169
>>
>> Ok. I don't care about it.
>> Greg: Can you please add any of this patch to your char-misc tree?
>
> I did that yesterday, can't you see it in there already, or did I mess
> something up?

You have applied
drivers: uio_dmem_genirq: Use of_match_ptr() macro
(sha1: 077797117dfa209717e1f3f1416c1101c0e047f0)

which is for uio_dmem_genirq.c
and there is one more for uio_pdrv_genirq.c driver
which we have talked about with Sachin.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature

2013-06-26 17:12:09

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] uio: Use of_match_ptr() macro in uio_pdrv_genirq.c

On Wed, Jun 26, 2013 at 05:06:32PM +0200, Michal Simek wrote:
> On 06/26/2013 05:00 PM, Greg Kroah-Hartman wrote:
> > On Wed, Jun 26, 2013 at 12:21:27PM +0200, Michal Simek wrote:
> >> On 06/26/2013 12:00 PM, Sachin Kamat wrote:
> >>> On 26 June 2013 15:22, Michal Simek <[email protected]> wrote:
> >>>> This eliminates having an #ifdef returning NULL for the case
> >>>> when OF is disabled.
> >>>>
> >>>> Signed-off-by: Michal Simek <[email protected]>
> >>>
> >>> I have already submitted a similar patch for doing this:
> >>> https://lkml.org/lkml/2013/3/14/169
> >>
> >> Ok. I don't care about it.
> >> Greg: Can you please add any of this patch to your char-misc tree?
> >
> > I did that yesterday, can't you see it in there already, or did I mess
> > something up?
>
> You have applied
> drivers: uio_dmem_genirq: Use of_match_ptr() macro
> (sha1: 077797117dfa209717e1f3f1416c1101c0e047f0)
>
> which is for uio_dmem_genirq.c
> and there is one more for uio_pdrv_genirq.c driver
> which we have talked about with Sachin.

Oops, I did mess up, I forgot to push that patch out publically, I did
apply it yesterday, thanks for making me check :)

greg k-h

2013-06-26 23:17:10

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] uio: Remove uio_pdrv and use uio_pdrv_genirq instead

On Wed 2013-06-26 11:52:12, Michal Simek wrote:
> The patch "UIO: fix uio_pdrv_genirq with device tree but no interrupt"
> (sha1: e3a3c3a205554e564751cd9c0276b2af813d7a92)
> add support to use this driver with no interrupts.
> uio_pdrv_genirq also supports device-tree binding
> which is not available in uio_pdrv.
>
> That's why this uio_pdrv driver can be just removed.
>
> Signed-off-by: Michal Simek <[email protected]>

Reviewed-by: Pavel Machek <[email protected]>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2013-07-01 07:21:23

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] uio: Remove uio_pdrv and use uio_pdrv_genirq instead

Hi Greg,

On 06/27/2013 01:17 AM, Pavel Machek wrote:
> On Wed 2013-06-26 11:52:12, Michal Simek wrote:
>> The patch "UIO: fix uio_pdrv_genirq with device tree but no interrupt"
>> (sha1: e3a3c3a205554e564751cd9c0276b2af813d7a92)
>> add support to use this driver with no interrupts.
>> uio_pdrv_genirq also supports device-tree binding
>> which is not available in uio_pdrv.
>>
>> That's why this uio_pdrv driver can be just removed.
>>
>> Signed-off-by: Michal Simek <[email protected]>
>
> Reviewed-by: Pavel Machek <[email protected]>

I see 3.10 was tagged.
Are you going to add this patch to your char-misc tree?

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature

2013-07-01 17:20:26

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] uio: Remove uio_pdrv and use uio_pdrv_genirq instead

On Mon, Jul 01, 2013 at 09:21:14AM +0200, Michal Simek wrote:
> Hi Greg,
>
> On 06/27/2013 01:17 AM, Pavel Machek wrote:
> > On Wed 2013-06-26 11:52:12, Michal Simek wrote:
> >> The patch "UIO: fix uio_pdrv_genirq with device tree but no interrupt"
> >> (sha1: e3a3c3a205554e564751cd9c0276b2af813d7a92)
> >> add support to use this driver with no interrupts.
> >> uio_pdrv_genirq also supports device-tree binding
> >> which is not available in uio_pdrv.
> >>
> >> That's why this uio_pdrv driver can be just removed.
> >>
> >> Signed-off-by: Michal Simek <[email protected]>
> >
> > Reviewed-by: Pavel Machek <[email protected]>
>
> I see 3.10 was tagged.
> Are you going to add this patch to your char-misc tree?

I will consider it after 3.11-rc1 is out, it came too late in the 3.11
merge cycle for me to take it.

thanks,

greg k-h

2013-07-03 06:00:31

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] uio: Remove uio_pdrv and use uio_pdrv_genirq instead

On 07/01/2013 07:20 PM, Greg Kroah-Hartman wrote:
> On Mon, Jul 01, 2013 at 09:21:14AM +0200, Michal Simek wrote:
>> Hi Greg,
>>
>> On 06/27/2013 01:17 AM, Pavel Machek wrote:
>>> On Wed 2013-06-26 11:52:12, Michal Simek wrote:
>>>> The patch "UIO: fix uio_pdrv_genirq with device tree but no interrupt"
>>>> (sha1: e3a3c3a205554e564751cd9c0276b2af813d7a92)
>>>> add support to use this driver with no interrupts.
>>>> uio_pdrv_genirq also supports device-tree binding
>>>> which is not available in uio_pdrv.
>>>>
>>>> That's why this uio_pdrv driver can be just removed.
>>>>
>>>> Signed-off-by: Michal Simek <[email protected]>
>>>
>>> Reviewed-by: Pavel Machek <[email protected]>
>>
>> I see 3.10 was tagged.
>> Are you going to add this patch to your char-misc tree?
>
> I will consider it after 3.11-rc1 is out, it came too late in the 3.11
> merge cycle for me to take it.

No problem. I will keep my eyes on it.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature