2013-05-02 12:51:14

by Robert Richter

Subject: [PATCH] Makefile: Fix install error with make -j option

From: Robert Richter <[email protected]>

Make modules_install fails with -j option:

DEPMOD
Usage: .../.source/linux/scripts/depmod.sh /sbin/depmod <kernelrelease>
make[1]: *** [_modinst_post] Error 1

Adding kernelrelease dependency to fix this.

Signed-off-by: Robert Richter <[email protected]>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 46263d8..0205e79 100644
--- a/Makefile
+++ b/Makefile
@@ -979,7 +979,7 @@ _modinst_:
# boot a modules.dep even before / is mounted read-write. However the
# boot script depmod is the master version.
PHONY += _modinst_post
-_modinst_post: _modinst_
+_modinst_post: include/config/kernel.release _modinst_
$(Q)$(MAKE) -f $(srctree)/scripts/Makefile.fwinst obj=firmware __fw_modinst
$(call cmd,depmod)

--
1.8.1.1

2013-06-12 10:14:00

by Robert Richter

Subject: Re: [PATCH] Makefile: Fix install error with make -j option

Michal,

please apply this fix, ideally for v3.10 if possible.

Thanks,

-Robert


On 02.05.13 08:50:37, Robert Richter wrote:
> From: Robert Richter <[email protected]>
>
> Make modules_install fails with -j option:
>
> DEPMOD
> Usage: .../.source/linux/scripts/depmod.sh /sbin/depmod <kernelrelease>
> make[1]: *** [_modinst_post] Error 1
>
> Adding kernelrelease dependency to fix this.
>
> Signed-off-by: Robert Richter <[email protected]>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 46263d8..0205e79 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -979,7 +979,7 @@ _modinst_:
> # boot a modules.dep even before / is mounted read-write. However the
> # boot script depmod is the master version.
> PHONY += _modinst_post
> -_modinst_post: _modinst_
> +_modinst_post: include/config/kernel.release _modinst_
> $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.fwinst obj=firmware __fw_modinst
> $(call cmd,depmod)
>
> --
> 1.8.1.1
>

2013-07-03 12:59:14

by Michal Marek

Subject: Re: [PATCH] Makefile: Fix install error with make -j option

On Wed, Jun 12, 2013 at 12:13:47PM +0200, Robert Richter wrote:
> Michal,
>
> please apply this fix, ideally for v3.10 if possible.

I applied it to kbuild.git#kbuild now, with Cc:
<[email protected]>.

Michal
>
> Thanks,
>
> -Robert
>
>
> On 02.05.13 08:50:37, Robert Richter wrote:
> > From: Robert Richter <[email protected]>
> >
> > Make modules_install fails with -j option:
> >
> > DEPMOD
> > Usage: .../.source/linux/scripts/depmod.sh /sbin/depmod <kernelrelease>
> > make[1]: *** [_modinst_post] Error 1
> >
> > Adding kernelrelease dependency to fix this.
> >
> > Signed-off-by: Robert Richter <[email protected]>
> > ---
> > Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 46263d8..0205e79 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -979,7 +979,7 @@ _modinst_:
> > # boot a modules.dep even before / is mounted read-write. However the
> > # boot script depmod is the master version.
> > PHONY += _modinst_post
> > -_modinst_post: _modinst_
> > +_modinst_post: include/config/kernel.release _modinst_
> > $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.fwinst obj=firmware __fw_modinst
> > $(call cmd,depmod)
> >
> > --
> > 1.8.1.1
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html