2013-07-02 17:09:29

by Hartley Sweeten

[permalink] [raw]
Subject: [PATCH v2 06/11] spi: spi-ep93xx: remove dev_err() for kzalloc() failure

The kzalloc() failure will have already output a message.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Ryan Mallon <[email protected]>
Cc: Mika Westerberg <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Grant Likely <[email protected]>
---
drivers/spi/spi-ep93xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index c1a610e..34aade1 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -1004,10 +1004,8 @@ static int ep93xx_spi_probe(struct platform_device *pdev)
}

master = spi_alloc_master(&pdev->dev, sizeof(*espi));
- if (!master) {
- dev_err(&pdev->dev, "failed to allocate spi master\n");
+ if (!master)
return -ENOMEM;
- }

master->setup = ep93xx_spi_setup;
master->transfer = ep93xx_spi_transfer;
--
1.8.1.4


2013-07-03 18:06:13

by Mika Westerberg

[permalink] [raw]
Subject: Re: [PATCH v2 06/11] spi: spi-ep93xx: remove dev_err() for kzalloc() failure

On Tue, Jul 02, 2013 at 10:08:59AM -0700, H Hartley Sweeten wrote:
> The kzalloc() failure will have already output a message.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Ryan Mallon <[email protected]>
> Cc: Mika Westerberg <[email protected]>

Acked-by: Mika Westerberg <[email protected]>

2013-07-03 18:22:45

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2 06/11] spi: spi-ep93xx: remove dev_err() for kzalloc() failure

On Tue, Jul 02, 2013 at 10:08:59AM -0700, H Hartley Sweeten wrote:
> The kzalloc() failure will have already output a message.

Applied, thanks.


Attachments:
(No filename) (145.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments