2013-07-08 07:23:07

by Konstantin Khlebnikov

[permalink] [raw]
Subject: [PATCH] drivers/net: igb: release rtnl_lock on error path

This adds missing rtnl_unlock()

Signed-off-by: Konstantin Khlebnikov <[email protected]>
Cc: Jeff Kirsher <[email protected]>
Cc: [email protected]
---
drivers/net/ethernet/intel/igb/igb_main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 64cbe0d..86ac29d 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7235,6 +7235,7 @@ static int igb_sriov_reinit(struct pci_dev *dev)
igb_init_queue_configuration(adapter);

if (igb_init_interrupt_scheme(adapter, true)) {
+ rtnl_unlock();
dev_err(&pdev->dev, "Unable to allocate memory for queues\n");
return -ENOMEM;
}


2013-07-08 19:37:51

by Jeff Kirsher

[permalink] [raw]
Subject: Re: [PATCH] drivers/net: igb: release rtnl_lock on error path

On Mon, 2013-07-08 at 11:22 +0400, Konstantin Khlebnikov wrote:
> This adds missing rtnl_unlock()
>
> Signed-off-by: Konstantin Khlebnikov <[email protected]>
> Cc: Jeff Kirsher <[email protected]>
> Cc: [email protected]
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 1 +
> 1 file changed, 1 insertion(+)

I thought I already had this in my queue, if not I will add it. Thanks
Konstantin.


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part