2013-07-15 15:29:15

by Tim Gardner

Subject: [PATCH 3.11-rc1] mlx5 core: Fix __udivdi3 when compiling for 32 bit arches

Cc: Eli Cohen <[email protected]>
Signed-off-by: Tim Gardner <[email protected]>
---
drivers/net/ethernet/mellanox/mlx5/core/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c b/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c
index 4273c06..9c7194b 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c
@@ -156,7 +156,7 @@ static ssize_t average_read(struct file *filp, char __user *buf, size_t count,
stats = filp->private_data;
spin_lock(&stats->lock);
if (stats->n)
- field = stats->sum / stats->n;
+ field = div64_u64(stats->sum, stats->n);
spin_unlock(&stats->lock);
ret = snprintf(tbuf, sizeof(tbuf), "%llu\n", field);
if (ret > 0) {
--
1.7.9.5

2013-07-15 15:53:06

by Randy Dunlap

Subject: Re: [PATCH 3.11-rc1] mlx5 core: Fix __udivdi3 when compiling for 32 bit arches

On 07/15/13 07:56, Tim Gardner wrote:
> Cc: Eli Cohen <[email protected]>
> Signed-off-by: Tim Gardner <[email protected]>

I reported this last week and Eli wrote:

"I have this fixed in my tree and we run the driver on i386. I will check on Sunday why it is not in the patches submitted."

Anyway, the patch works for me.

Acked-by: Randy Dunlap <[email protected]>
Reported-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> drivers/net/ethernet/mellanox/mlx5/core/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c b/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c
> index 4273c06..9c7194b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c
> @@ -156,7 +156,7 @@ static ssize_t average_read(struct file *filp, char __user *buf, size_t count,
> stats = filp->private_data;
> spin_lock(&stats->lock);
> if (stats->n)
> - field = stats->sum / stats->n;
> + field = div64_u64(stats->sum, stats->n);
> spin_unlock(&stats->lock);
> ret = snprintf(tbuf, sizeof(tbuf), "%llu\n", field);
> if (ret > 0) {
>


--
~Randy

2013-07-15 20:45:55

by Tim Gardner

Subject: Re: [PATCH 3.11-rc1] mlx5 core: Fix __udivdi3 when compiling for 32 bit arches

On 07/15/2013 09:52 AM, Randy Dunlap wrote:
> On 07/15/13 07:56, Tim Gardner wrote:
>> Cc: Eli Cohen <[email protected]> Signed-off-by: Tim Gardner
>> <[email protected]>
>
> I reported this last week and Eli wrote:
>
> "I have this fixed in my tree and we run the driver on i386. I will
> check on Sunday why it is not in the patches submitted."
>
> Anyway, the patch works for me.
>
> Acked-by: Randy Dunlap <[email protected]> Reported-by: Randy
> Dunlap <[email protected]>
>

I figured someone must have seen it, but a cursory Google search on
"mlx5 __udivdi3" failed to turn up anything.

rtg
--
Tim Gardner [email protected]

2013-07-16 19:37:01

by David Miller

Subject: Re: [PATCH 3.11-rc1] mlx5 core: Fix __udivdi3 when compiling for 32 bit arches

From: Randy Dunlap <[email protected]>
Date: Mon, 15 Jul 2013 08:52:18 -0700

> On 07/15/13 07:56, Tim Gardner wrote:
>> Cc: Eli Cohen <[email protected]>
>> Signed-off-by: Tim Gardner <[email protected]>
>
> I reported this last week and Eli wrote:
>
> "I have this fixed in my tree and we run the driver on i386. I will check on Sunday why it is not in the patches submitted."
>
> Anyway, the patch works for me.
>
> Acked-by: Randy Dunlap <[email protected]>
> Reported-by: Randy Dunlap <[email protected]>

Applied, thanks.