2013-07-17 03:41:37

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the final tree (aio tree related)

Hi all,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:

fs/aio.c: In function 'aio_migratepage':
fs/aio.c:196:2: error: implicit declaration of function 'migrate_page_move_mapping' [-Werror=implicit-function-declaration]
rc = migrate_page_move_mapping(mapping, new, old, NULL, mode);
^

Caused by commit 36bc08cc0170 ("fs/aio: Add support to aio ring pages
migration"). The declaration of migrate_page_move_mapping() in
linux/migrate.h is protected by CONFIG_MIGRATION - its use in fs/aio.c is
not. So the usage needs to be protected, or there needs to be a dummy
version in linux/migrate.h

I have reverted that commit for today.

--
Cheers,
Stephen Rothwell [email protected]


Attachments:
(No filename) (755.00 B)
(No filename) (836.00 B)
Download all attachments

2013-07-17 13:46:43

by Benjamin LaHaise

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the final tree (aio tree related)

Hello Stephen, (actually a greeting this time!)

On Wed, Jul 17, 2013 at 01:41:24PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allnoconfig) failed like this:
>
> fs/aio.c: In function 'aio_migratepage':
> fs/aio.c:196:2: error: implicit declaration of function 'migrate_page_move_mapping' [-Werror=implicit-function-declaration]
> rc = migrate_page_move_mapping(mapping, new, old, NULL, mode);
> ^
>
> Caused by commit 36bc08cc0170 ("fs/aio: Add support to aio ring pages
> migration"). The declaration of migrate_page_move_mapping() in
> linux/migrate.h is protected by CONFIG_MIGRATION - its use in fs/aio.c is
> not. So the usage needs to be protected, or there needs to be a dummy
> version in linux/migrate.h

I have added and tested a fix for this issue and pushed it out to my
tree. Thanks for the report -- I'll try to be a bit more careful.

-ben

> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell [email protected]



--
"Thought is the essence of where you are now."