2013-07-26 12:05:04

by Michael Brunner

[permalink] [raw]
Subject: [PATCH] i2c: Fix Kontron PLD prescaler calculation

Add some necessary braces that have been removed during driver cleanup.
This fixes the I2C prescaler calculation.

Signed-off-by: Michael Brunner <[email protected]>
---
drivers/i2c/busses/i2c-kempld.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-kempld.c b/drivers/i2c/busses/i2c-kempld.c
index ccec916..af8f65f 100644
--- a/drivers/i2c/busses/i2c-kempld.c
+++ b/drivers/i2c/busses/i2c-kempld.c
@@ -246,9 +246,9 @@ static void kempld_i2c_device_init(struct kempld_i2c_data *i2c)
bus_frequency = KEMPLD_I2C_FREQ_MAX;

if (pld->info.spec_major == 1)
- prescale = pld->pld_clock / bus_frequency * 5 - 1000;
+ prescale = pld->pld_clock / (bus_frequency * 5) - 1000;
else
- prescale = pld->pld_clock / bus_frequency * 4 - 3000;
+ prescale = pld->pld_clock / (bus_frequency * 4) - 3000;

if (prescale < 0)
prescale = 0;


2013-08-02 03:48:34

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] i2c: Fix Kontron PLD prescaler calculation

On Fri, Jul 26, 2013 at 02:04:55PM +0200, Michael Brunner wrote:
> Add some necessary braces that have been removed during driver cleanup.
> This fixes the I2C prescaler calculation.
>
> Signed-off-by: Michael Brunner <[email protected]>

Tested-by: Guenter Roeck <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>

Guenter

2013-08-05 08:35:20

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: Fix Kontron PLD prescaler calculation

On Fri, Jul 26, 2013 at 02:04:55PM +0200, Michael Brunner wrote:
> Add some necessary braces that have been removed during driver cleanup.
> This fixes the I2C prescaler calculation.
>
> Signed-off-by: Michael Brunner <[email protected]>

Applied to for-current, thanks!


Attachments:
(No filename) (283.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments