2013-07-30 00:28:08

by Dave Jones

[permalink] [raw]
Subject: Re: drm/crtc-helper: explicit DPMS on after modeset

On Tue, Jul 23, 2013 at 11:08:14PM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=25f397a429dfa43f22c278d0119a60a343aa568f
> Commit: 25f397a429dfa43f22c278d0119a60a343aa568f
> Author: Daniel Vetter <[email protected]>
> AuthorDate: Fri Jul 19 18:57:11 2013 +0200
> Committer: Dave Airlie <[email protected]>
> CommitDate: Mon Jul 22 09:55:17 2013 +1000
>
> drm/crtc-helper: explicit DPMS on after modeset

> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -677,6 +677,11 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set)
> /* don't break so fail path works correct */
> fail = 1;
> break;
> +
> + if (connector->dpms != DRM_MODE_DPMS_ON) {
> + DRM_DEBUG_KMS("connector dpms not on, full mode switch\n");
> + mode_changed = true;
> + }
> }

This code will never get executed. (See the break above it).

Dave