2013-08-01 13:04:01

by Olaf Hering

Subject: [PATCH] Tools: hv: check return value of system in hv_kvp_daemon

hv_kvp_daemon.c: In function 'main':
hv_kvp_daemon.c:1441:8: warning: ignoring return value of 'daemon', declared with attribute warn_unused_result [-Wunused-result]

Signed-off-by: Olaf Hering <[email protected]>
---
tools/hv/hv_kvp_daemon.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index ba075e5..b96eccc 100644
--- a/tools/hv/hv_kvp_daemon.c
+++ b/tools/hv/hv_kvp_daemon.c
@@ -1353,7 +1353,11 @@ setval_done:
*/

snprintf(cmd, sizeof(cmd), "%s %s", "hv_set_ifconfig", if_file);
- system(cmd);
+ if (system(cmd)) {
+ syslog(LOG_ERR, "Failed to execute cmd '%s'; error: %d %s",
+ cmd, errno, strerror(errno));
+ return HV_E_FAIL;
+ }
return 0;

setval_error:

2013-08-01 14:52:48

by KY Srinivasan

Subject: RE: [PATCH] Tools: hv: check return value of system in hv_kvp_daemon

> -----Original Message-----
> From: Olaf Hering [mailto:[email protected]]
> Sent: Thursday, August 01, 2013 9:04 AM
> To: KY Srinivasan; [email protected]
> Cc: [email protected]; Olaf Hering
> Subject: [PATCH] Tools: hv: check return value of system in hv_kvp_daemon
>
> hv_kvp_daemon.c: In function 'main':
> hv_kvp_daemon.c:1441:8: warning: ignoring return value of 'daemon', declared
> with attribute warn_unused_result [-Wunused-result]
>
> Signed-off-by: Olaf Hering <[email protected]>
Signed-off-by: K. Y. Srinivasan <[email protected]>
> ---
> tools/hv/hv_kvp_daemon.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index ba075e5..b96eccc 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -1353,7 +1353,11 @@ setval_done:
> */
>
> snprintf(cmd, sizeof(cmd), "%s %s", "hv_set_ifconfig", if_file);
> - system(cmd);
> + if (system(cmd)) {
> + syslog(LOG_ERR, "Failed to execute cmd '%s'; error: %d %s",
> + cmd, errno, strerror(errno));
> + return HV_E_FAIL;
> + }
> return 0;
>
> setval_error:
>
>

2013-08-02 03:10:38

by Greg Kroah-Hartman

Subject: Re: [PATCH] Tools: hv: check return value of system in hv_kvp_daemon

On Thu, Aug 01, 2013 at 02:36:10PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: Olaf Hering [mailto:[email protected]]
> > Sent: Thursday, August 01, 2013 9:04 AM
> > To: KY Srinivasan; [email protected]
> > Cc: [email protected]; Olaf Hering
> > Subject: [PATCH] Tools: hv: check return value of system in hv_kvp_daemon
> >
> > hv_kvp_daemon.c: In function 'main':
> > hv_kvp_daemon.c:1441:8: warning: ignoring return value of 'daemon', declared
> > with attribute warn_unused_result [-Wunused-result]
> >
> > Signed-off-by: Olaf Hering <[email protected]>
> Signed-off-by: K. Y. Srinivasan <[email protected]>

Can you please resend this to me, I don't seem to have a copy of it
anywhere.

thanks,

greg k-h