2013-08-06 21:11:33

by Philip J. Kelleher

[permalink] [raw]
Subject: [PATCH 2/4] rsxx: Removing IDA on driver unload.

From: Philip J Kelleher <[email protected]>

The rsxx driver was not releasing the IDA entry during
driver unload. This would be a big problem on a DLPAR
remove where the card is remove from the LPAR but the
driver is still loaded. This patch fixes that issue.

Signed-off-by: Philip J Kelleher <[email protected]>
-------------------------------------------------------------------------------


diff -uprN -X linux-block-vanilla/Documentation/dontdiff linux-block-vanilla/drivers/block/rsxx/core.c linux-block/drivers/block/rsxx/core.c
--- linux-block-vanilla/drivers/block/rsxx/core.c 2013-07-23 10:11:20.943772116 -0500
+++ linux-block/drivers/block/rsxx/core.c 2013-07-23 10:14:50.402462948 -0500
@@ -1105,6 +1105,10 @@ static void rsxx_pci_remove(struct pci_d
pci_disable_device(dev);
pci_release_regions(dev);

+ spin_lock(&rsxx_ida_lock);
+ ida_remove(&rsxx_disk_ida, card->disk_id);
+ spin_unlock(&rsxx_ida_lock);
+
kfree(card);
}