2013-08-14 09:49:52

by Dan Carpenter

Subject: [patch] efs: iget_locked() doesn't return an ERR_PTR()

The iget_locked() function returns NULL on error and never an ERR_PTR.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/fs/efs/inode.c b/fs/efs/inode.c
index f3913eb..d15ccf2 100644
--- a/fs/efs/inode.c
+++ b/fs/efs/inode.c
@@ -57,7 +57,7 @@ struct inode *efs_iget(struct super_block *super, unsigned long ino)
struct inode *inode;

inode = iget_locked(super, ino);
- if (IS_ERR(inode))
+ if (!inode)
return ERR_PTR(-ENOMEM);
if (!(inode->i_state & I_NEW))
return inode;

2013-08-14 11:58:00

by Serge E. Hallyn

Subject: Re: [patch] efs: iget_locked() doesn't return an ERR_PTR()

Quoting Dan Carpenter ([email protected]):
> The iget_locked() function returns NULL on error and never an ERR_PTR.
>
> Signed-off-by: Dan Carpenter <[email protected]>

Acked-by: Serge Hallyn <[email protected]>

> diff --git a/fs/efs/inode.c b/fs/efs/inode.c
> index f3913eb..d15ccf2 100644
> --- a/fs/efs/inode.c
> +++ b/fs/efs/inode.c
> @@ -57,7 +57,7 @@ struct inode *efs_iget(struct super_block *super, unsigned long ino)
> struct inode *inode;
>
> inode = iget_locked(super, ino);
> - if (IS_ERR(inode))
> + if (!inode)
> return ERR_PTR(-ENOMEM);
> if (!(inode->i_state & I_NEW))
> return inode;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/