2013-08-20 07:01:30

by Jingoo Han

[permalink] [raw]
Subject: [PATCH 1/3] mfd: pm8921: include missing linux/module.h

Include <linux/module.h> in order to fix the following errors.

drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or '...' before string constant
drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or '...' before string constant
drivers/mfd/pm8921-core.c:211:16: error: expected declaration specifiers or '...' before string constant
drivers/mfd/pm8921-core.c:212:14: error: expected declaration specifiers or '...' before string constant

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/mfd/pm8921-core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
index 9be6840..bd4b37c 100644
--- a/drivers/mfd/pm8921-core.c
+++ b/drivers/mfd/pm8921-core.c
@@ -14,6 +14,7 @@
#define pr_fmt(fmt) "%s: " fmt, __func__

#include <linux/kernel.h>
+#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/err.h>
--
1.7.10.4


2013-08-20 07:28:50

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH 1/3] mfd: pm8921: include missing linux/module.h

On Tue, 20 Aug 2013, Jingoo Han wrote:

> Include <linux/module.h> in order to fix the following errors.
>
> drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or '...' before string constant
> drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or '...' before string constant
> drivers/mfd/pm8921-core.c:211:16: error: expected declaration specifiers or '...' before string constant
> drivers/mfd/pm8921-core.c:212:14: error: expected declaration specifiers or '...' before string constant
>
> Signed-off-by: Jingoo Han <[email protected]>

Patches look good to me 1-3 applied.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2013-08-20 18:31:17

by David Brown

[permalink] [raw]
Subject: Re: [PATCH 1/3] mfd: pm8921: include missing linux/module.h

On Tue, Aug 20, 2013 at 04:01:26PM +0900, Jingoo Han wrote:
>Include <linux/module.h> in order to fix the following errors.
>
>drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or '...' before string constant
>drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or '...' before string constant
>drivers/mfd/pm8921-core.c:211:16: error: expected declaration specifiers or '...' before string constant
>drivers/mfd/pm8921-core.c:212:14: error: expected declaration specifiers or '...' before string constant
>
>Signed-off-by: Jingoo Han <[email protected]>
>---
> drivers/mfd/pm8921-core.c | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: David Brown <[email protected]>

--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation