2013-08-22 02:21:01

by Jingoo Han

Subject: [PATCH] w1: mxc_w1: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/w1/masters/mxc_w1.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/w1/masters/mxc_w1.c b/drivers/w1/masters/mxc_w1.c
index 47e12cf..15c7251 100644
--- a/drivers/w1/masters/mxc_w1.c
+++ b/drivers/w1/masters/mxc_w1.c
@@ -152,8 +152,6 @@ static int mxc_w1_remove(struct platform_device *pdev)

clk_disable_unprepare(mdev->clk);

- platform_set_drvdata(pdev, NULL);
-
return 0;
}

--
1.7.10.4

2013-08-23 02:43:28

by Shawn Guo

Subject: Re: [PATCH] w1: mxc_w1: remove unnecessary platform_set_drvdata()

On Thu, Aug 22, 2013 at 11:20:58AM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <[email protected]>

Acked-by: Shawn Guo <[email protected]>

> ---
> drivers/w1/masters/mxc_w1.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/w1/masters/mxc_w1.c b/drivers/w1/masters/mxc_w1.c
> index 47e12cf..15c7251 100644
> --- a/drivers/w1/masters/mxc_w1.c
> +++ b/drivers/w1/masters/mxc_w1.c
> @@ -152,8 +152,6 @@ static int mxc_w1_remove(struct platform_device *pdev)
>
> clk_disable_unprepare(mdev->clk);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
> --
> 1.7.10.4
>
>