2013-08-16 18:07:11

by Mike Frysinger

[permalink] [raw]
Subject: [PATCH] Omnikey Cardman 4000: pull in ioctl.h in user header

This file uses the ioctl helpers (_IOR/_IOW/etc...), so include ioctl.h
for the definitions.

Signed-off-by: Mike Frysinger <[email protected]>
---
include/uapi/linux/cm4000_cs.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/cm4000_cs.h b/include/uapi/linux/cm4000_cs.h
index bc51f77..1217f75 100644
--- a/include/uapi/linux/cm4000_cs.h
+++ b/include/uapi/linux/cm4000_cs.h
@@ -2,6 +2,7 @@
#define _UAPI_CM4000_H_

#include <linux/types.h>
+#include <linux/ioctl.h>

#define MAX_ATR 33

--
1.8.3.2


2013-08-22 22:55:47

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] Omnikey Cardman 4000: pull in ioctl.h in user header

On Fri, 16 Aug 2013 14:07:09 -0400 Mike Frysinger <[email protected]> wrote:

> This file uses the ioctl helpers (_IOR/_IOW/etc...), so include ioctl.h
> for the definitions.
>
> ...
>
> --- a/include/uapi/linux/cm4000_cs.h
> +++ b/include/uapi/linux/cm4000_cs.h
> @@ -2,6 +2,7 @@
> #define _UAPI_CM4000_H_
>
> #include <linux/types.h>
> +#include <linux/ioctl.h>
>
> #define MAX_ATR 33

I'm assuming this fixes a build error under unknown circumstances, or
not, or something else?

2013-08-24 21:54:39

by Mike Frysinger

[permalink] [raw]
Subject: Re: [PATCH] Omnikey Cardman 4000: pull in ioctl.h in user header

On Thursday 22 August 2013 18:55:45 Andrew Morton wrote:
> On Fri, 16 Aug 2013 14:07:09 -0400 Mike Frysinger wrote:
> > This file uses the ioctl helpers (_IOR/_IOW/etc...), so include ioctl.h
> > for the definitions.
> >
> > ...
> >
> > --- a/include/uapi/linux/cm4000_cs.h
> > +++ b/include/uapi/linux/cm4000_cs.h
> > @@ -2,6 +2,7 @@
> > #define _UAPI_CM4000_H_
> >
> > #include <linux/types.h>
> > +#include <linux/ioctl.h>
> >
> > #define MAX_ATR 33
>
> I'm assuming this fixes a build error under unknown circumstances, or
> not, or something else?

yes, it's to fix a build error. i don't have any specific source packages that
are known to fail though. just doing analysis of the headers by grep/eye.
-mike


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part.