2013-08-23 12:07:55

by Sachin Kamat

Subject: [PATCH 1/1] mfd: ab8500-debugfs: Staticize local variables

Local variables referenced only in this file are made static.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/mfd/ab8500-debugfs.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index 7d1f1b0..a0afa64 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -159,7 +159,7 @@ static struct hwreg_cfg hwreg_cfg = {

static struct ab8500_prcmu_ranges *debug_ranges;

-struct ab8500_prcmu_ranges ab8500_debug_ranges[AB8500_NUM_BANKS] = {
+static struct ab8500_prcmu_ranges ab8500_debug_ranges[AB8500_NUM_BANKS] = {
[0x0] = {
.num_ranges = 0,
.range = NULL,
@@ -488,7 +488,7 @@ struct ab8500_prcmu_ranges ab8500_debug_ranges[AB8500_NUM_BANKS] = {
},
};

-struct ab8500_prcmu_ranges ab8505_debug_ranges[AB8500_NUM_BANKS] = {
+static struct ab8500_prcmu_ranges ab8505_debug_ranges[AB8500_NUM_BANKS] = {
[0x0] = {
.num_ranges = 0,
.range = NULL,
@@ -847,7 +847,7 @@ struct ab8500_prcmu_ranges ab8505_debug_ranges[AB8500_NUM_BANKS] = {
},
};

-struct ab8500_prcmu_ranges ab8540_debug_ranges[AB8500_NUM_BANKS] = {
+static struct ab8500_prcmu_ranges ab8540_debug_ranges[AB8500_NUM_BANKS] = {
[AB8500_M_FSM_RANK] = {
.num_ranges = 1,
.range = (struct ab8500_reg_range[]) {
@@ -1377,7 +1377,7 @@ void ab8500_dump_all_banks(struct device *dev)

/* Space for 500 registers. */
#define DUMP_MAX_REGS 700
-struct ab8500_register_dump
+static struct ab8500_register_dump
{
u8 bank;
u8 reg;
--
1.7.4.1

2013-08-23 18:56:35

by Linus Walleij

Subject: Re: [PATCH 1/1] mfd: ab8500-debugfs: Staticize local variables

On Fri, Aug 23, 2013 at 2:07 PM, Sachin Kamat <[email protected]> wrote:

> Local variables referenced only in this file are made static.
>
> Signed-off-by: Sachin Kamat <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2013-08-27 08:29:11

by Lee Jones

Subject: Re: [PATCH 1/1] mfd: ab8500-debugfs: Staticize local variables

On Fri, 23 Aug 2013, Sachin Kamat wrote:

> Local variables referenced only in this file are made static.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/mfd/ab8500-debugfs.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)

Applied with Linus' Ack.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog