2013-08-05 12:21:18

by Jiri Kosina

Subject: [PATCH] nohz: put proper symbol in the unstable schedclock warning

Since e12d0271 ("nohz: Warn if the machine can not perform nohz_full")
Kernel triggers a WARN() in case sched clock is marked as unstable.

Make it output a proper Kconfig symbol (NO_HZ_FULL) when informing user
about this.

Signed-off-by: Jiri Kosina <[email protected]>
---
kernel/time/tick-sched.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index e77edc9..e0030ed 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -182,7 +182,7 @@ static bool can_stop_full_tick(void)
* Don't allow the user to think they can get
* full NO_HZ with this machine.
*/
- WARN_ONCE(1, "NO_HZ FULL will not work with unstable sched clock");
+ WARN_ONCE(1, "NO_HZ_FULL will not work with unstable sched clock");
return false;
}
#endif

--
Jiri Kosina
SUSE Labs

2013-08-30 11:38:31

by Frederic Weisbecker

Subject: Re: [PATCH] nohz: put proper symbol in the unstable schedclock warning

On Mon, Aug 05, 2013 at 02:21:13PM +0200, Jiri Kosina wrote:
> Since e12d0271 ("nohz: Warn if the machine can not perform nohz_full")
> Kernel triggers a WARN() in case sched clock is marked as unstable.
>
> Make it output a proper Kconfig symbol (NO_HZ_FULL) when informing user
> about this.
>
> Signed-off-by: Jiri Kosina <[email protected]>

I'm queuing this, thanks!

> ---
> kernel/time/tick-sched.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index e77edc9..e0030ed 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -182,7 +182,7 @@ static bool can_stop_full_tick(void)
> * Don't allow the user to think they can get
> * full NO_HZ with this machine.
> */
> - WARN_ONCE(1, "NO_HZ FULL will not work with unstable sched clock");
> + WARN_ONCE(1, "NO_HZ_FULL will not work with unstable sched clock");
> return false;
> }
> #endif
>
> --
> Jiri Kosina
> SUSE Labs