2013-09-03 20:31:08

by Joe Perches

Subject: [PATCH] pci.h: Fix typo, remove unnecessary !!

Use normal kernel-doc "Returns:" instead of retruns
Assignment to bool is always 1 or 0 so the !! isn't necessary.

Signed-off-by: Joe Perches <[email protected]>
---
include/linux/pci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index da172f9..ee0f3b6 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1749,11 +1749,11 @@ static inline int pci_pcie_cap(struct pci_dev *dev)
* pci_is_pcie - check if the PCI device is PCI Express capable
* @dev: PCI device
*
- * Retrun true if the PCI device is PCI Express capable, false otherwise.
+ * Returns: true if the PCI device is PCI Express capable, false otherwise.
*/
static inline bool pci_is_pcie(struct pci_dev *dev)
{
- return !!pci_pcie_cap(dev);
+ return pci_pcie_cap(dev);
}

/**

2013-09-03 23:10:56

by Bjorn Helgaas

Subject: Re: [PATCH] pci.h: Fix typo, remove unnecessary !!

On Tue, Sep 03, 2013 at 01:31:05PM -0700, Joe Perches wrote:
> Use normal kernel-doc "Returns:" instead of retruns
> Assignment to bool is always 1 or 0 so the !! isn't necessary.
>
> Signed-off-by: Joe Perches <[email protected]>

Applied to pci/misc, thanks. This branch will be rebased and will
not appear in -next until after v3.12-rc1.

> ---
> include/linux/pci.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index da172f9..ee0f3b6 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1749,11 +1749,11 @@ static inline int pci_pcie_cap(struct pci_dev *dev)
> * pci_is_pcie - check if the PCI device is PCI Express capable
> * @dev: PCI device
> *
> - * Retrun true if the PCI device is PCI Express capable, false otherwise.
> + * Returns: true if the PCI device is PCI Express capable, false otherwise.
> */
> static inline bool pci_is_pcie(struct pci_dev *dev)
> {
> - return !!pci_pcie_cap(dev);
> + return pci_pcie_cap(dev);
> }
>
> /**
>
>