Hello,
I am late into the discussion about the DA9063 driver because I missed
the e-mail thread around 24th July
(https://lkml.org/lkml/2013/7/24/460)
so I only recently noticed that a DA9063 driver from Philipp Zabel
had been submitted and accepted to linux-next.
I also noted that this driver was using a previous patch-set as its baseline;
sent by Krystian Garbaciak over a year ago. Given that this original
patch-set was not accepted, and the production of the DA9063 chip has
advanced since the last submission, we were holding off the final DA9063
driver until later.
As I discussed earlier in https://lkml.org/lkml/2013/6/28/170 I was in
the process of getting this driver ready for submission to the kernel.
It is well understood that any early submission of our driver to the
community (around v3.6) meant that this sort of external driver development
could happen without any further input from Dialog. However, this driver:
- is based on something that is a year old and now out of date;
- it cannot support the most recent mass-production release of DA9063 silicon;
Is it possible to remove this driver from linux-next so these issues
can be resolved by Dialog?
Regards,
Steve Twiss
Could copy me the mfd.c file of da9063 in the lkml?
-----Original Message-----
From: Steve Twiss
Sent: 06 September 2013 11:48
To: Mark Brown; Philipp Zabel
Cc: Lee Jones; Samuel Ortiz; LKML
Subject: DA9063 driver development
Hello,
I am late into the discussion about the DA9063 driver because I missed the e-mail thread around 24th July
(https://lkml.org/lkml/2013/7/24/460)
so I only recently noticed that a DA9063 driver from Philipp Zabel had been submitted and accepted to linux-next.
I also noted that this driver was using a previous patch-set as its baseline; sent by Krystian Garbaciak over a year ago. Given that this original patch-set was not accepted, and the production of the DA9063 chip has advanced since the last submission, we were holding off the final DA9063 driver until later.
As I discussed earlier in https://lkml.org/lkml/2013/6/28/170 I was in the process of getting this driver ready for submission to the kernel.
It is well understood that any early submission of our driver to the community (around v3.6) meant that this sort of external driver development could happen without any further input from Dialog. However, this driver:
- is based on something that is a year old and now out of date;
- it cannot support the most recent mass-production release of DA9063 silicon;
Is it possible to remove this driver from linux-next so these issues can be resolved by Dialog?
Regards,
Steve Twiss
Legal Disclaimer: This e-mail communication (and any attachment/s) is confidential and contains proprietary information, some or all of which may be legally privileged. It is intended solely for the use of the individual or entity to which it is addressed. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.
Please consider the environment before printing this e-mail
Hi Steve,
See my answers below:
On Fri, Sep 06, 2013 at 10:47:58AM +0000, Steve Twiss wrote:
> Hello,
>
> I am late into the discussion about the DA9063 driver because I missed
> the e-mail thread around 24th July
> (https://lkml.org/lkml/2013/7/24/460)
> so I only recently noticed that a DA9063 driver from Philipp Zabel
> had been submitted and accepted to linux-next.
>
> I also noted that this driver was using a previous patch-set as its baseline;
> sent by Krystian Garbaciak over a year ago. Given that this original
> patch-set was not accepted, and the production of the DA9063 chip has
> advanced since the last submission, we were holding off the final DA9063
> driver until later.
>
> As I discussed earlier in https://lkml.org/lkml/2013/6/28/170 I was in
> the process of getting this driver ready for submission to the kernel.
>
> It is well understood that any early submission of our driver to the
> community (around v3.6) meant that this sort of external driver development
> could happen without any further input from Dialog. However, this driver:
>
> - is based on something that is a year old and now out of date;
> - it cannot support the most recent mass-production release of DA9063 silicon;
>
> Is it possible to remove this driver from linux-next so these issues
> can be resolved by Dialog?
Unfortunately it's too late for that. I sent a pull request to Linus
with this driver included, so I expect it to hit Linus' tree anytime
soon.
That means that it will be part of the 3.12-rc1 release. The good news
here is that we have about 8 weeks to modify it to match your recent
development, before 3.12 is released.
I would really prefer to modify the now existing driver and improve it,
rather than revert it.
Cheers,
Samuel.
> Regards,
> Steve Twiss
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
On Fri, Sep 06, 2013 at 10:47:58AM +0000, Steve Twiss wrote:
> Is it possible to remove this driver from linux-next so these issues
> can be resolved by Dialog?
No, sorry. The regulator tree has already been merged into Linus' tree
for v3.12 so can't be changed now.
In any case the best approach to a situation like this is to make
incremental improvements to the code in mainline rather than just throw
out the existing code and start over. This ensures that no work done on
the mainline version during or after merge gets lost. The best way to
avoid this happening is to submit drivers as soon as you can, and of
course to make sure that any code sent to mainline is reviewed.