2013-09-10 11:13:55

by Sachin Kamat

Subject: [PATCH 1/1] mfd: aat2870: Fix sparse error

Fixes the following error:
drivers/mfd/aat2870-core.c:296:20: error:
incompatible types in comparison expression (different type sizes)

Signed-off-by: Sachin Kamat <[email protected]>
Cc: Jin Park <[email protected]>
---
drivers/mfd/aat2870-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/aat2870-core.c b/drivers/mfd/aat2870-core.c
index 6f68472..14d9542 100644
--- a/drivers/mfd/aat2870-core.c
+++ b/drivers/mfd/aat2870-core.c
@@ -293,7 +293,7 @@ static ssize_t aat2870_reg_write_file(struct file *file,
unsigned long addr, val;
int ret;

- buf_size = min(count, (sizeof(buf)-1));
+ buf_size = min(count, (size_t)(sizeof(buf)-1));
if (copy_from_user(buf, user_buf, buf_size)) {
dev_err(aat2870->dev, "Failed to copy from user\n");
return -EFAULT;
--
1.7.9.5

2013-09-10 11:20:24

by Lee Jones

Subject: Re: [PATCH 1/1] mfd: aat2870: Fix sparse error

On Tue, 10 Sep 2013, Sachin Kamat wrote:

> Fixes the following error:
> drivers/mfd/aat2870-core.c:296:20: error:
> incompatible types in comparison expression (different type sizes)
>
> Signed-off-by: Sachin Kamat <[email protected]>
> Cc: Jin Park <[email protected]>
> ---
> drivers/mfd/aat2870-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/aat2870-core.c b/drivers/mfd/aat2870-core.c
> index 6f68472..14d9542 100644
> --- a/drivers/mfd/aat2870-core.c
> +++ b/drivers/mfd/aat2870-core.c
> @@ -293,7 +293,7 @@ static ssize_t aat2870_reg_write_file(struct file *file,
> unsigned long addr, val;
> int ret;
>
> - buf_size = min(count, (sizeof(buf)-1));
> + buf_size = min(count, (size_t)(sizeof(buf)-1));
> if (copy_from_user(buf, user_buf, buf_size)) {
> dev_err(aat2870->dev, "Failed to copy from user\n");
> return -EFAULT;

Applied, thanks.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog