2013-09-06 12:04:17

by Sachin Kamat

Subject: [PATCH 1/1] dma: tegra20-apb-dma: Staticize tegra_dma_prep_dma_cyclic

tegra_dma_prep_dma_cyclic is referenced only in this file.
Make it static.

Signed-off-by: Sachin Kamat <[email protected]>
Cc: Laxman Dewangan <[email protected]>
---
drivers/dma/tegra20-apb-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 5d4986e..67a6752 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -1018,7 +1018,7 @@ static struct dma_async_tx_descriptor *tegra_dma_prep_slave_sg(
return &dma_desc->txd;
}

-struct dma_async_tx_descriptor *tegra_dma_prep_dma_cyclic(
+static struct dma_async_tx_descriptor *tegra_dma_prep_dma_cyclic(
struct dma_chan *dc, dma_addr_t buf_addr, size_t buf_len,
size_t period_len, enum dma_transfer_direction direction,
unsigned long flags, void *context)
--
1.7.9.5

2013-09-09 02:44:25

by Laxman Dewangan

Subject: Re: [PATCH 1/1] dma: tegra20-apb-dma: Staticize tegra_dma_prep_dma_cyclic

On Friday 06 September 2013 05:16 PM, Sachin Kamat wrote:
> tegra_dma_prep_dma_cyclic is referenced only in this file.
> Make it static.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> Cc: Laxman Dewangan <[email protected]>
> ---
>
Agree, looks good.

Acked-by: Laxman Dewangan <[email protected]>

2013-09-17 05:48:06

by Vinod Koul

Subject: Re: [PATCH 1/1] dma: tegra20-apb-dma: Staticize tegra_dma_prep_dma_cyclic

On Fri, Sep 06, 2013 at 05:16:22PM +0530, Sachin Kamat wrote:
> tegra_dma_prep_dma_cyclic is referenced only in this file.
> Make it static.
Applied, thanks

~Vinod
>
> Signed-off-by: Sachin Kamat <[email protected]>
> Cc: Laxman Dewangan <[email protected]>
> ---
> drivers/dma/tegra20-apb-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index 5d4986e..67a6752 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -1018,7 +1018,7 @@ static struct dma_async_tx_descriptor *tegra_dma_prep_slave_sg(
> return &dma_desc->txd;
> }
>
> -struct dma_async_tx_descriptor *tegra_dma_prep_dma_cyclic(
> +static struct dma_async_tx_descriptor *tegra_dma_prep_dma_cyclic(
> struct dma_chan *dc, dma_addr_t buf_addr, size_t buf_len,
> size_t period_len, enum dma_transfer_direction direction,
> unsigned long flags, void *context)
> --
> 1.7.9.5
>

--