2013-09-23 15:54:33

by Julia Lawall

Subject: question tehuti.c

The function bdx_setmulti in the file drivers/net/ethernet/tehuti/tehuti.c
contains:

u32 rxf_val =
GMAC_RX_FILTER_AM | GMAC_RX_FILTER_AB | GMAC_RX_FILTER_OSEN;

and then later:

} else {
DBG("only own mac %d\n", netdev_mc_count(ndev));
rxf_val |= GMAC_RX_FILTER_AB;
}

The last assignment doesn't look very useful, because GMAC_RX_FILTER_ABis
already included in rxf_val. Was something else intended?

thanks,
julia

2013-09-24 15:39:41

by Andy Gospodarek

Subject: Re: question tehuti.c

On Mon, Sep 23, 2013 at 05:54:00PM +0200, Julia Lawall wrote:
> The function bdx_setmulti in the file drivers/net/ethernet/tehuti/tehuti.c
> contains:
>
> u32 rxf_val =
> GMAC_RX_FILTER_AM | GMAC_RX_FILTER_AB | GMAC_RX_FILTER_OSEN;
>
> and then later:
>
> } else {
> DBG("only own mac %d\n", netdev_mc_count(ndev));
> rxf_val |= GMAC_RX_FILTER_AB;
> }
>
> The last assignment doesn't look very useful, because GMAC_RX_FILTER_ABis
> already included in rxf_val. Was something else intended?

You are correct that the setting of GMAC_RX_FILTER_AB is a bit redundant
since it was set earlier in the function.

I have not worked on this driver in several years and if there is no
response from Alexander or someone else at Tehuti Networks then you may
not get an answer to your question. :-/