2013-09-28 17:55:59

by Myron Stowe

[permalink] [raw]
Subject: [PATCH] cris/PCI: Remove pci_mem_start

Remove unused 'pci_mem_start' variable.

CC: Mikael Starvik <[email protected]>
CC: Jesper Nilsson <[email protected]>
Signed-off-by: Myron Stowe <[email protected]>
---

arch/cris/include/asm/pci.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/cris/include/asm/pci.h b/arch/cris/include/asm/pci.h
index 146da90..f666734 100644
--- a/arch/cris/include/asm/pci.h
+++ b/arch/cris/include/asm/pci.h
@@ -11,7 +11,6 @@

#define pcibios_assign_all_busses(void) 1

-extern unsigned long pci_mem_start;
#define PCIBIOS_MIN_IO 0x1000
#define PCIBIOS_MIN_MEM 0x10000000


2013-10-04 20:21:57

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [PATCH] cris/PCI: Remove pci_mem_start

On Sat, Sep 28, 2013 at 11:55 AM, Myron Stowe <[email protected]> wrote:
> Remove unused 'pci_mem_start' variable.
>
> CC: Mikael Starvik <[email protected]>
> CC: Jesper Nilsson <[email protected]>
> Signed-off-by: Myron Stowe <[email protected]>

Applied to pci/misc, thanks!

It'd be nice if we could someday get rid of PCIBIOS_MIN_IO and
PCIBIOS_MIN_MEM, too. They're really just relics from the days when
we assumed there was a single host bridge, and we didn't have any idea
what the host bridge apertures were (or we assumed the host bridge
essentially subtractively decoded everything).

Now that we can tell the PCI core about host bridge apertures, the
arch should be able to achieve the effect of PCIBIOS_MIN_MEM by
clipping the window itself.

Bjorn

> ---
>
> arch/cris/include/asm/pci.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/cris/include/asm/pci.h b/arch/cris/include/asm/pci.h
> index 146da90..f666734 100644
> --- a/arch/cris/include/asm/pci.h
> +++ b/arch/cris/include/asm/pci.h
> @@ -11,7 +11,6 @@
>
> #define pcibios_assign_all_busses(void) 1
>
> -extern unsigned long pci_mem_start;
> #define PCIBIOS_MIN_IO 0x1000
> #define PCIBIOS_MIN_MEM 0x10000000
>
>