2013-10-01 21:29:02

by David Cohen

Subject: [PATCH v2 1/2] usb: chipidea: cosmetic clean up on pci id list

In order to fill a struct with zeroes just the first element needs to
be set to 0, the rest can me omitted. This looks cleaner when reading
the code.

This patch does such clean up change on last item of pci id list.

Signed-off-by: David Cohen <[email protected]>
---
drivers/usb/chipidea/ci_hdrc_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/chipidea/ci_hdrc_pci.c b/drivers/usb/chipidea/ci_hdrc_pci.c
index 042320a..08a724b 100644
--- a/drivers/usb/chipidea/ci_hdrc_pci.c
+++ b/drivers/usb/chipidea/ci_hdrc_pci.c
@@ -129,7 +129,7 @@ static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = {
PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829),
.driver_data = (kernel_ulong_t)&penwell_pci_platdata,
},
- { 0, 0, 0, 0, 0, 0, 0 /* end: all zeroes */ }
+ { 0 } /* end: all zeroes */
};
MODULE_DEVICE_TABLE(pci, ci_hdrc_pci_id_table);

--
1.8.4.rc3

2013-10-01 21:29:03

by David Cohen

Subject: [PATCH v2 2/2] usb: chipidea: add Intel Clovertrail pci id

Signed-off-by: David Cohen <[email protected]>
---
drivers/usb/chipidea/ci_hdrc_pci.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/usb/chipidea/ci_hdrc_pci.c b/drivers/usb/chipidea/ci_hdrc_pci.c
index 08a724b..d514332 100644
--- a/drivers/usb/chipidea/ci_hdrc_pci.c
+++ b/drivers/usb/chipidea/ci_hdrc_pci.c
@@ -129,6 +129,11 @@ static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = {
PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829),
.driver_data = (kernel_ulong_t)&penwell_pci_platdata,
},
+ {
+ /* Intel Clovertrail */
+ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe006),
+ .driver_data = (kernel_ulong_t)&penwell_pci_platdata,
+ },
{ 0 } /* end: all zeroes */
};
MODULE_DEVICE_TABLE(pci, ci_hdrc_pci_id_table);
--
1.8.4.rc3

2013-10-03 05:21:24

by Greg Kroah-Hartman

Subject: Re: [PATCH v2 2/2] usb: chipidea: add Intel Clovertrail pci id

On Tue, Oct 01, 2013 at 02:32:58PM -0700, David Cohen wrote:
> Signed-off-by: David Cohen <[email protected]>
> ---
> drivers/usb/chipidea/ci_hdrc_pci.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_pci.c b/drivers/usb/chipidea/ci_hdrc_pci.c
> index 08a724b..d514332 100644
> --- a/drivers/usb/chipidea/ci_hdrc_pci.c
> +++ b/drivers/usb/chipidea/ci_hdrc_pci.c
> @@ -129,6 +129,11 @@ static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = {
> PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829),
> .driver_data = (kernel_ulong_t)&penwell_pci_platdata,
> },
> + {
> + /* Intel Clovertrail */
> + PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe006),
> + .driver_data = (kernel_ulong_t)&penwell_pci_platdata,
> + },

Can this go into 3.12-final, and any other stable kernel releases as
well? Or does this platform also need other fixes that aren't in 3.10
and 3.11?

thanks,

greg k-h

2013-10-03 16:05:33

by David Cohen

Subject: Re: [PATCH v2 2/2] usb: chipidea: add Intel Clovertrail pci id

Hi Greg,

On 10/02/2013 10:21 PM, Greg KH wrote:
> On Tue, Oct 01, 2013 at 02:32:58PM -0700, David Cohen wrote:
>> Signed-off-by: David Cohen <[email protected]>
>> ---
>> drivers/usb/chipidea/ci_hdrc_pci.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/usb/chipidea/ci_hdrc_pci.c b/drivers/usb/chipidea/ci_hdrc_pci.c
>> index 08a724b..d514332 100644
>> --- a/drivers/usb/chipidea/ci_hdrc_pci.c
>> +++ b/drivers/usb/chipidea/ci_hdrc_pci.c
>> @@ -129,6 +129,11 @@ static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = {
>> PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829),
>> .driver_data = (kernel_ulong_t)&penwell_pci_platdata,
>> },
>> + {
>> + /* Intel Clovertrail */
>> + PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe006),
>> + .driver_data = (kernel_ulong_t)&penwell_pci_platdata,
>> + },
>
> Can this go into 3.12-final, and any other stable kernel releases as
> well? Or does this platform also need other fixes that aren't in 3.10
> and 3.11?

This was tested on 3.10+
It might work on 3.4 but it's not validated. I can test it if we care
about chipidea on 3.4.

Br, David

>
> thanks,
>
> greg k-h
>

2013-10-03 22:41:35

by Greg Kroah-Hartman

Subject: Re: [PATCH v2 2/2] usb: chipidea: add Intel Clovertrail pci id

On Thu, Oct 03, 2013 at 09:04:04AM -0700, David Cohen wrote:
> Hi Greg,
>
> On 10/02/2013 10:21 PM, Greg KH wrote:
> >On Tue, Oct 01, 2013 at 02:32:58PM -0700, David Cohen wrote:
> >>Signed-off-by: David Cohen <[email protected]>
> >>---
> >> drivers/usb/chipidea/ci_hdrc_pci.c | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >>diff --git a/drivers/usb/chipidea/ci_hdrc_pci.c b/drivers/usb/chipidea/ci_hdrc_pci.c
> >>index 08a724b..d514332 100644
> >>--- a/drivers/usb/chipidea/ci_hdrc_pci.c
> >>+++ b/drivers/usb/chipidea/ci_hdrc_pci.c
> >>@@ -129,6 +129,11 @@ static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = {
> >> PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829),
> >> .driver_data = (kernel_ulong_t)&penwell_pci_platdata,
> >> },
> >>+ {
> >>+ /* Intel Clovertrail */
> >>+ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe006),
> >>+ .driver_data = (kernel_ulong_t)&penwell_pci_platdata,
> >>+ },
> >
> >Can this go into 3.12-final, and any other stable kernel releases as
> >well? Or does this platform also need other fixes that aren't in 3.10
> >and 3.11?
>
> This was tested on 3.10+
> It might work on 3.4 but it's not validated. I can test it if we
> care about chipidea on 3.4.

I doubt anyone cares about chipidea on 3.4, 3.10 is good enough. I've
mushed these patches together into one to make it easier to backport and
apply to Linus's tree for 3.12-final.

thanks,

greg k-h