2013-09-30 12:06:37

by Thierry Reding

Subject: [PATCH] ARM: imx: Include linux/err.h

The IS_ERR() macro is defined in the linux/err.h header file, so include
it explicitly.

Signed-off-by: Thierry Reding <[email protected]>
---
arch/arm/mach-imx/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/cpu.c b/arch/arm/mach-imx/cpu.c
index fae2c9a..ba3b498 100644
--- a/arch/arm/mach-imx/cpu.c
+++ b/arch/arm/mach-imx/cpu.c
@@ -1,4 +1,4 @@
-
+#include <linux/err.h>
#include <linux/module.h>
#include <linux/io.h>
#include <linux/of.h>
--
1.8.4

2013-10-05 02:25:39

by Shawn Guo

Subject: Re: [PATCH] ARM: imx: Include linux/err.h

On Mon, Sep 30, 2013 at 02:04:51PM +0200, Thierry Reding wrote:
> The IS_ERR() macro is defined in the linux/err.h header file, so include
> it explicitly.

Hmm, I can not find IS_ERR() in arch/arm/mach-imx/cpu.c

Shawn

> Signed-off-by: Thierry Reding <[email protected]>
> ---
> arch/arm/mach-imx/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/cpu.c b/arch/arm/mach-imx/cpu.c
> index fae2c9a..ba3b498 100644
> --- a/arch/arm/mach-imx/cpu.c
> +++ b/arch/arm/mach-imx/cpu.c
> @@ -1,4 +1,4 @@
> -
> +#include <linux/err.h>
> #include <linux/module.h>
> #include <linux/io.h>
> #include <linux/of.h>
> --
> 1.8.4
>

2013-10-05 02:28:15

by Shawn Guo

Subject: Re: [PATCH] ARM: imx: Include linux/err.h

On Sat, Oct 05, 2013 at 10:24:23AM +0800, Shawn Guo wrote:
> On Mon, Sep 30, 2013 at 02:04:51PM +0200, Thierry Reding wrote:
> > The IS_ERR() macro is defined in the linux/err.h header file, so include
> > it explicitly.
>
> Hmm, I can not find IS_ERR() in arch/arm/mach-imx/cpu.c

Sorry, I did not look at the correct tree.

Applied, thanks.

Shawn