2013-10-08 18:17:10

by Jean-Francois Moine

Subject: [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio

As defined in the DT, clkout2 is not allowed to change the pll inside
si5351.

This patch extends the properties of clkout2 so that it works as the
external clock of the audio device in the Cubox.

Also, as the second si5351 clock is not used in the Cubox, its
definition is removed.

Signed-off-by: Jean-Francois Moine <[email protected]>
---
v2:
- remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
---
arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
index bb38a24..3dd8844 100644
--- a/arch/arm/boot/dts/dove-cubox.dts
+++ b/arch/arm/boot/dts/dove-cubox.dts
@@ -99,18 +99,12 @@
silabs,pll-master;
};

- clkout1 {
- reg = <1>;
- silabs,drive-strength = <8>;
- silabs,multisynth-source = <1>;
- silabs,clock-source = <0>;
- silabs,pll-master;
- };
-
clkout2 {
reg = <2>;
+ silabs,drive-strength = <8>;
silabs,multisynth-source = <1>;
silabs,clock-source = <0>;
+ silabs,pll-master;
};
};
};


--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/

2013-10-08 18:20:03

by Sebastian Hesselbarth

Subject: Re: [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio

On 10/08/2013 08:20 PM, Jean-Francois Moine wrote:
> As defined in the DT, clkout2 is not allowed to change the pll inside
> si5351.
>
> This patch extends the properties of clkout2 so that it works as the
> external clock of the audio device in the Cubox.
>
> Also, as the second si5351 clock is not used in the Cubox, its
> definition is removed.
>
> Signed-off-by: Jean-Francois Moine <[email protected]>

Already gave my

Acked-by: Sebastian Hesselbarth <[email protected]>

which you should add to help us keep track of them next time.

> ---
> v2:
> - remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
> ---
> arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
> index bb38a24..3dd8844 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -99,18 +99,12 @@
> silabs,pll-master;
> };
>
> - clkout1 {
> - reg = <1>;
> - silabs,drive-strength = <8>;
> - silabs,multisynth-source = <1>;
> - silabs,clock-source = <0>;
> - silabs,pll-master;
> - };
> -
> clkout2 {
> reg = <2>;
> + silabs,drive-strength = <8>;
> silabs,multisynth-source = <1>;
> silabs,clock-source = <0>;
> + silabs,pll-master;
> };
> };
> };
>
>

2013-10-09 13:24:11

by Jason Cooper

Subject: Re: [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio

On Tue, Oct 08, 2013 at 08:20:27PM +0200, Jean-Francois Moine wrote:
> As defined in the DT, clkout2 is not allowed to change the pll inside
> si5351.
>
> This patch extends the properties of clkout2 so that it works as the
> external clock of the audio device in the Cubox.
>
> Also, as the second si5351 clock is not used in the Cubox, its
> definition is removed.
>
> Signed-off-by: Jean-Francois Moine <[email protected]>
> ---
> v2:
> - remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
> ---
> arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)

Applied to mvebu/dt with Sebastian's Ack.

thx,

Jason.