2013-10-10 00:51:16

by Olof Johansson

[permalink] [raw]
Subject: Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

Hi,

On Wed, Sep 26, 2012 at 5:48 AM, Laxman Dewangan <[email protected]> wrote:
> Driver throw the warning message if dt node does not
> have the info for VMBCH-Threshold and VMBCH2-Threshold.
> These properties are optional property and hence it
> is not mandatory to have these on DT node and in this case
> it should not throw the warning message.
> It creates noise from driver as follows:
> [ 0.384605] tps65910 4-002d: VMBCH-Threshold not specified
> [ 0.384616] tps65910 4-002d: VMBCH2-Threshold not specified
>
> Removing the warning message from driver.
>
> Signed-off-by: Laxman Dewangan <[email protected]>
> ---
> It seems orginal patch has been lost. Reposting it.

I still see this with 3.12-rc. Sam?


2013-10-10 13:29:24

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

Hi Olof,

On Wed, Oct 09, 2013 at 05:51:14PM -0700, Olof Johansson wrote:
> Hi,
>
> On Wed, Sep 26, 2012 at 5:48 AM, Laxman Dewangan <[email protected]> wrote:
> > Driver throw the warning message if dt node does not
> > have the info for VMBCH-Threshold and VMBCH2-Threshold.
> > These properties are optional property and hence it
> > is not mandatory to have these on DT node and in this case
> > it should not throw the warning message.
> > It creates noise from driver as follows:
> > [ 0.384605] tps65910 4-002d: VMBCH-Threshold not specified
> > [ 0.384616] tps65910 4-002d: VMBCH2-Threshold not specified
> >
> > Removing the warning message from driver.
> >
> > Signed-off-by: Laxman Dewangan <[email protected]>
> > ---
> > It seems orginal patch has been lost. Reposting it.
>
> I still see this with 3.12-rc. Sam?
I can take it through mfd-next, but do you really think it's material
for mfd-fixes ?

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

2013-10-10 15:46:24

by Olof Johansson

[permalink] [raw]
Subject: Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

Hi,

On Thu, Oct 10, 2013 at 6:26 AM, Samuel Ortiz <[email protected]> wrote:
> Hi Olof,
>
> On Wed, Oct 09, 2013 at 05:51:14PM -0700, Olof Johansson wrote:
>> Hi,
>>
>> On Wed, Sep 26, 2012 at 5:48 AM, Laxman Dewangan <[email protected]> wrote:
>> > Driver throw the warning message if dt node does not
>> > have the info for VMBCH-Threshold and VMBCH2-Threshold.
>> > These properties are optional property and hence it
>> > is not mandatory to have these on DT node and in this case
>> > it should not throw the warning message.
>> > It creates noise from driver as follows:
>> > [ 0.384605] tps65910 4-002d: VMBCH-Threshold not specified
>> > [ 0.384616] tps65910 4-002d: VMBCH2-Threshold not specified
>> >
>> > Removing the warning message from driver.
>> >
>> > Signed-off-by: Laxman Dewangan <[email protected]>
>> > ---
>> > It seems orginal patch has been lost. Reposting it.
>>
>> I still see this with 3.12-rc. Sam?
> I can take it through mfd-next, but do you really think it's material
> for mfd-fixes ?

Oh, 3.13 is definitely fine, it'd just be good to see it not fall
between the cracks. It's a harmless warning.


-Olof