2013-10-08 10:44:40

by Majunath Goudar

Subject: [PATCH] SOUND/SPI: Fix "clk_round_rate" undefined reference error.

This patch adds a COMMON_CLK dependency to configure the
SND_AT73C213 for Atmel AT73C213 DAC driver. Without this patch,
build system can lead to build failure. This was observed during
randconfig testing, in which SND_AT73C213 was enabled w/o COMMON_CLK
being enabled. leading to the following error:

sound/built-in.o: In function `snd_at73c213_probe':
:(.text+0x328c4): undefined reference to `clk_round_rate'
make: *** [vmlinux] Error 1

Signed-off-by: Manjunath Goudar <[email protected]>
Cc: Dmitry Torokhov <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
sound/spi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/spi/Kconfig b/sound/spi/Kconfig
index e6485be..798d1ee 100644
--- a/sound/spi/Kconfig
+++ b/sound/spi/Kconfig
@@ -11,7 +11,7 @@ if SND_SPI

config SND_AT73C213
tristate "Atmel AT73C213 DAC driver"
- depends on ATMEL_SSC
+ depends on ATMEL_SSC && COMMON_CLK
select SND_PCM
help
Say Y here if you want to use the Atmel AT73C213 external DAC. This
--
1.7.9.5

2013-10-22 22:54:04

by Dmitry Torokhov

Subject: Re: [PATCH] SOUND/SPI: Fix "clk_round_rate" undefined reference error.

Hi Majunath,

On Tue, Oct 08, 2013 at 04:10:33PM +0530, Majunath Goudar wrote:
> This patch adds a COMMON_CLK dependency to configure the
> SND_AT73C213 for Atmel AT73C213 DAC driver. Without this patch,
> build system can lead to build failure. This was observed during
> randconfig testing, in which SND_AT73C213 was enabled w/o COMMON_CLK
> being enabled. leading to the following error:
>
> sound/built-in.o: In function `snd_at73c213_probe':
> :(.text+0x328c4): undefined reference to `clk_round_rate'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Manjunath Goudar <[email protected]>
> Cc: Dmitry Torokhov <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> sound/spi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/spi/Kconfig b/sound/spi/Kconfig
> index e6485be..798d1ee 100644
> --- a/sound/spi/Kconfig
> +++ b/sound/spi/Kconfig
> @@ -11,7 +11,7 @@ if SND_SPI
>
> config SND_AT73C213
> tristate "Atmel AT73C213 DAC driver"
> - depends on ATMEL_SSC
> + depends on ATMEL_SSC && COMMON_CLK

I do not see clk_round_rate() being protected by CONFIG_COMMON_CLK so it
looks to me that ATMEL_SSC is at fault here.

Thanks.

--
Dmitry